Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bridge] Add /debug/version endpoint #10426

Merged
merged 3 commits into from
Jun 21, 2022
Merged

[bridge] Add /debug/version endpoint #10426

merged 3 commits into from
Jun 21, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jun 2, 2022 •
edited
Loading

Description

This PR makes ws-manager-bridge more debuggable.

Related Issue(s)

Context: #9395

How to test

  • start a workspace on this branch and ./dev/preview/install-k3s-kubeconfig.sh
  • use gpctl debug log ws-manager-bridge to switch log level to debug at runtime (already did this on this deployment)
  • check the logs for a) the "enabled"-message and b) for DEBUG logs

Release Notes

add /debug/version endpoint to ws-manager-bridge

Documentation

@geropl geropl requested a review from a team June 2, 2022 08:43
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 2, 2022
@geropl geropl changed the title [bridge] Use PrebuildUpdater in MetaInstanceController when stopping workspace instances waiting for a imagebuild [bridge] Use PrebuildUpdater in MetaInstanceController when stopping workspace instances waiting for a imagebuild (3/3) Jun 2, 2022
@AlexTugarev
Copy link
Member

AlexTugarev commented Jun 2, 2022 •
edited by werft-gitpod-dev-com bot
Loading

and make the image build timeout 1min (done ✔️ )

which attribute to set for this, @geropl ?

@geropl geropl force-pushed the gpl/9395-stuck-prebuilds-2 branch from ddd06f0 to 40a3e5d Compare June 2, 2022 12:01
@geropl geropl marked this pull request as draft June 2, 2022 12:05
Base automatically changed from gpl/9395-stuck-prebuilds-2 to main June 2, 2022 12:29
@roboquat roboquat added size/L and removed size/XS labels Jun 2, 2022
@geropl geropl force-pushed the gpl/9395-stuck-prebuilds-3 branch from d9dea34 to b0d8e55 Compare June 2, 2022 12:36
@geropl
Copy link
Member Author

geropl commented Jun 2, 2022

@AlexTugarev There seems to be a deeper issue with the MetaInstanceController... I will debug and fix next week! 👍

@jldec
Copy link
Contributor

jldec commented Jun 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-gpl-9395-stuck-prebuilds-3.3
(with .werft/ from main)

@geropl
Copy link
Member Author

geropl commented Jun 8, 2022

@jldec This is in draft mode, so no build needed.

@geropl geropl force-pushed the gpl/9395-stuck-prebuilds-3 branch from 1779d6e to c630512 Compare June 10, 2022 14:39
@geropl geropl force-pushed the gpl/9395-stuck-prebuilds-3 branch 3 times, most recently from 1abd8b6 to 2c5c81e Compare June 17, 2022 11:14
@roboquat roboquat added size/S and removed size/XL labels Jun 17, 2022
@geropl geropl force-pushed the gpl/9395-stuck-prebuilds-3 branch from 2c5c81e to eda5e31 Compare June 17, 2022 11:15
@geropl geropl changed the title [bridge] Use PrebuildUpdater in MetaInstanceController when stopping workspace instances waiting for a imagebuild (3/3) [bridge] Add /debug/version endpoint Jun 17, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gpl-9395-stuck-prebuilds-3.12 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gpl-9395-stuck-prebuilds-3.13 because the annotations in the pull request description changed
(with .werft/ from main)

@geropl
Copy link
Member Author

geropl commented Jun 20, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-gpl-9395-stuck-prebuilds-3.14
(with .werft/ from main)

@geropl geropl force-pushed the gpl/9395-stuck-prebuilds-3 branch from eda5e31 to 58bef6c Compare June 20, 2022 07:16
@geropl geropl marked this pull request as ready for review June 20, 2022 07:26
easyCZ
easyCZ approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

components/ws-manager-bridge/src/bridge-controller.ts
@@ -64,7 +64,7 @@ export class BridgeController {
protected async reconcile() {
return this.reconcileQueue.enqueue(async () => {
const allClusters = await this.getAllWorkspaceClusters();
log.info("reconciling clusters...", { allClusters: Array.from(allClusters.values()) });
log.info("reconciling clusters...", { allClusters: Array.from(allClusters.keys()) });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Logs should start with first letter uppercase

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to help setup a guideline for this. As long as we don't have that I think it's out of scope here. 🙂

@geropl
Copy link
Member Author

geropl commented Jun 21, 2022

Thx @easyCZ !

/unhold

@roboquat roboquat merged commit a921c14 into main Jun 21, 2022
@roboquat roboquat deleted the gpl/9395-stuck-prebuilds-3 branch June 21, 2022 07:07
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geropl @AlexTugarev @jldec @easyCZ @roboquat