Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] hide feedback form from self-hosted users 10296 #10297

Merged
merged 2 commits into from
May 27, 2022

Conversation

laushinka
Copy link
Contributor

Description

Hides the feedback form from self-hosted users.

Related Issue(s)

Fixes #10296

How to test

Release Notes

Feedback form only shows for SaaS gitpod-io users.

Documentation

@laushinka laushinka requested a review from a team May 27, 2022 10:12
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 27, 2022
@laushinka laushinka requested a review from jldec May 27, 2022 10:13
@laushinka laushinka changed the title [dashboard] hide feedback form for 10296 [dashboard] hide feedback form from self-hosted users 10296 May 27, 2022
@laushinka
Copy link
Contributor Author

Thanks, @easyCZ!

@laushinka
Copy link
Contributor Author

laushinka commented May 27, 2022

I'm sure this change works and it's reviewed already too, but just to be sure, @lucasvaltl I assume you have a self-hosted instance that you use to test? Is it worth testing this PR with that? 🙏🏽 I'd also like to know how to test it for future reference..

@roboquat roboquat merged commit a0e21bc into main May 27, 2022
@roboquat roboquat deleted the laushinka/hide-feedback-form-for-10296 branch May 27, 2022 13:45
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Hide Feedback Form for self-hosted
3 participants