Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove kedge #10292

Merged
merged 1 commit into from
May 27, 2022
Merged

[cleanup] Remove kedge #10292

merged 1 commit into from
May 27, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented May 27, 2022

Description

Removes all code and links to kedge.
This has not been used actively since February, and definitely not deployed since our installer migration 2 weeks ago.

Related Issue(s)

Fixes #9487

How to test

Release Notes

remove kedge

Documentation

@geropl geropl marked this pull request as ready for review May 27, 2022 07:25
@geropl geropl requested review from a team May 27, 2022 07:25
@github-actions github-actions bot added team: IDE team: webapp Issue belongs to the WebApp team labels May 27, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd recommend staging the removal. We need to get into the habit of not changing application and configuration and expect them to be in perfect sync always.

Up to you if you want to tackle the comments, but I'd recommend it.

/hold

@@ -29,7 +29,6 @@ type Components struct {
} `json:"imageBuilderMk3"`
InstallationTelemetry Versioned `json:"installationTelemetry"`
IntegrationTests Versioned `json:"integrationTests"`
Kedge Versioned `json:"kedge"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I'd recommend renaming this to _ to make it unused in the first phase of removal. Config can be really nasty and sometimes you've got old versions of config that do define this field. We'll fail to parse the json/yaml when there are fields which are not defined in the struct.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got old versions of config that do define this field

Two comments on this:

  • this is the versions file. We don't use it as config, plus no-one should do so
  • if this were a relevant config field: instead of manually managing obsolescence of single fields, which involves multiple PRs, managing phase-out periods and such, we should instead make our parsing behavior in installer less picky (e.g., with a "warn but continue anyway" flag). The current hard lock-in between a) installer binary, b) versions file and c) config is not flexible enough for RL usecases.

We should be cautious where it make sense, but also watch out for our pace. 🙂

@geropl
Copy link
Member Author

geropl commented May 27, 2022

I'd recommend staging the removal. We need to get into the habit of not changing application and configuration and expect them to be in perfect sync always.

This has not been used actively since February, and definitely not deployed since our installer migration. (Updated the description).

@geropl
Copy link
Member Author

geropl commented May 27, 2022

/unhold

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only looked at my files

@roboquat roboquat merged commit c025034 into main May 27, 2022
@roboquat roboquat deleted the gpl/kedge branch May 27, 2022 09:21
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production deployed Change is completely running in production labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XXL team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get rid of kedge
4 participants