Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] add a metric to track volume snapshot time #10290

Merged
merged 3 commits into from
May 30, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented May 27, 2022

Description

Add a metric to track the volume snapshot time (the time it takes to create the volume snapshot of a workspace content).

Related Issue(s)

Partially #10195 (will have a PR for volume restore time)

How to test

  • Bootstrap a new workspace preview environment using the installer from this PR.
  • Add Git integration to GitHub.
  • Enable the feature flag persistent_volume_claim.
  • Create a new workspace, create a large file in the workspace and stop the workspace.
    dd if=/dev/urandom of=1G.random bs=16M count=64
  • Port forward metrics port of the ws-manager and look for new metrics.
    kubectl port-forward <ws-manager-pod-name> 9500:9500
    curl -XGET localhost:9500/metrics
  • The reported time gitpod_ws_manager_volume_snapshot_seconds_xxx should match the time it took to perform the volume snapshot.

Release Notes

[experimental] add a metric to track volume snapshot time

Documentation

@jenting
Copy link
Contributor Author

jenting commented May 27, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-jenting-observability-add-metrics-10195.5
(with .werft/ from main)

@jenting jenting force-pushed the jenting/observability-add-metrics-10195 branch 2 times, most recently from f10257c to 9076fb9 Compare May 27, 2022 11:34
@jenting jenting marked this pull request as ready for review May 27, 2022 12:05
@jenting jenting requested a review from a team May 27, 2022 12:05
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 27, 2022
@jenting jenting requested review from sagor999 and a team May 30, 2022 03:14
@jenting jenting force-pushed the jenting/observability-add-metrics-10195 branch from d07ef02 to 6770d3c Compare May 30, 2022 03:30
@roboquat roboquat merged commit 1fbffff into main May 30, 2022
@roboquat roboquat deleted the jenting/observability-add-metrics-10195 branch May 30, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

observability: add metrics so we can measure frequency and duration of PVC snapshot backup and restore
4 participants