[dashboard] remove deprecated tailwind-filter #10268
Conversation
flaming-codes
changed the title
|
Looking at this now! 👀 /werft run 👍 started the job as gitpod-build-chore-remove-deprecated-tailwind-filter-fork.0 |
There was a problem hiding this comment.
Thanks for contributing, @flaming-codes! ✨
Changes look good! However, the filters from tailwind do not seem to work over SVG images. Wondering if this is a known issue since [filter] property is expected to work with SVGs, too. 💭
| Login | Login (Repository) | First time log in modal | Preferences |
|---|---|---|---|
 |
 |
 |
 |
Let me spin up another preview environment instance below.
|
/werft run 👍 started the job as gitpod-build-chore-remove-deprecated-tailwind-filter-fork.1 |
|
You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓 |
|
Added missing utility class, as required by Tailwind 2.x. Whenever we upgrade to 3.x, the
|
|
/werft run 👍 started the job as gitpod-build-chore-remove-deprecated-tailwind-filter-fork.2 |
|
/werft run 👎 not authorized |
|
/werft run 👍 started the job as gitpod-build-chore-remove-deprecated-tailwind-filter-fork.3 |
gtsiolis
force-pushed
the
chore/remove-deprecated-tailwind-filter
branch
from
aba25af to
8f7302c
Compare
|
/werft run 👍 started the job as gitpod-build-chore-remove-deprecated-tailwind-filter-fork.4 |
|
/werft run 👍 started the job as gitpod-build-chore-remove-deprecated-tailwind-filter-fork.5 |
gtsiolis
force-pushed
the
chore/remove-deprecated-tailwind-filter
branch
from
8f7302c to
2aa0516
Compare
|
/werft run 👍 started the job as gitpod-build-chore-remove-deprecated-tailwind-filter-fork.6 |
|
@meysholdt I would really like to sign the CLA so that I can continue contributing to Gitpod. My email is [email protected]. Thanks! |
I already signed the CLA, is there anything more to do? Thanks! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@gtsiolis What's the status on this from your side? I signed the CLA a long time ago, is there anything to do on my part? Thanks! |
|
@flaming-codes Did you receive a CLA doc to sign from @meysholdt as described in #10268 (comment)? I've also asked the team internally to confirm. |
Yes, and I signed it some weeks ago. |
|
hi @flaming-codes, I checked, but we don't have a signed CLA from your on record. Maybe that is because the link from the comments above points to Googles CLA and not to Gitpods CLA. Apologies for the confustion. Can you please sign our CLA via this DocuSign form? If there are any questions, you can reach me via [email protected]. |
Delete this file because it led to confusion in #10268 (comment)
@meysholdt Great, thanks! I signed the doc provided by the link. |
meysholdt
added
cla: accepted ✔️
and removed
do-not-merge/cla-pending
|
Awesome, thank you! I've received the signed CLA and filed a PR to remove the misleading instructions: #11646 |
Delete this file because it led to confusion in #10268 (comment)
|
/werft run 👍 started the job as gitpod-build-chore-remove-deprecated-tailwind-filter-fork.7 |
|
/werft run with-preview 👍 started the job as gitpod-build-chore-remove-deprecated-tailwind-filter-fork.8 |
Delete this file because it led to confusion in gitpod-io#10268 (comment)
|
Due to the lack of action for a final review and me atm not having the necessary time to further work on it, I'm closing this PR. |
Description
Remove the depreacted tailwind-filters package and replace its usage w/ native tailwind utility classes.
Related Issue(s)
Fixes #10004
How to test
No specific test for these styles are available.
Release Notes
Documentation