Wait the Guest Client to be connected to the workspace before executing "gp preview" on JetBrains IDEs.

[felladrin]

Description

Wait the Guest Client to be connected to the workspace before executing "gp preview" on JetBrains IDEs.

Related Issue(s)

Fixes #10118

How to test

• Access the following URL to open Jenkins Design Library in Gitpod's Preview Environment in IntelliJ IDEA:
  https://vn-10118-j8f802b11df.preview.gitpod-dev.com/#referrer:jetbrains-gateway:intellij/https://github.com/jenkinsci/design-library-plugin/tree/73f12733d95932c333ba4155521ff78b4ed40dfc
• As soon as the IDE opens, it stats building the project. Meanwhile, if you want, you can use gp tasks attach to attach to "Preview" task. (See the project's .gitpod.yml)
• After the build completes, port 8080 will be available, and at this moment, the IDE should ask if you want to open the browser at the address $(gp url 8080)/jenkins/.
  
  
  Note: Sometimes the project build fails with messages like java: error reading /workspace/m2-repository/jaxen/jaxen/1.2.0/jaxen-1.2.0.jar; zip file is empty and the only solution is to manually delete the dependency folder (rm -rf /workspace/m2-repository/jaxen/) and then run mvn hpi:run again.
• Stop the workspace and restart it. Now the build will happen pretty quickly, as all dependencies are already downloaded. So as soon as you open the workspace on IntelliJ you should see the popup asking if you want to open Jenkins URL in the browser.

Release Notes

Fixed a bug that was preventing "gp preview" to work in JetBrains IDEs when executed as a task in ".gitpod.yml".

Documentation

None.

[felladrin]

I've noticed that if I stop the workspace, start it again and run gp tasks attach and select the Preview task, I always see the "500 Internal Server Error" message:

[felladrin]

I've noticed that if I stop the workspace, start it again and run gp tasks attach and select the Preview task, I always see the "500 Internal Server Error" message:

This has been fixed by the changes on GitpodCLIService.kt

[akosyakov]

@felladrin open --wait still does not work for me

I tried to perform git rebase -i origin/master and cli hangs for me forever:

[felladrin]

@felladrin open --wait still does not work for me

I tried to perform git rebase -i origin/master and cli hangs for me forever.

Seems to be an issue with JetBrains Remote Development, cause we need to click "Release" (in the editor) for it to detect that we finished working with the file. Closing the file tab doesn't work.

Let me confirm it with JetBrains team.

[akosyakov]

@felladrin Please open a follow up issue about broken gp open --wait, assign it to yourself and add to team sycn under port management for JB. We need to fix it with help of JB.

But since it is the same on master, let's merge to fix gp preview at least.

[felladrin]

@felladrin Please open a follow up issue about broken gp open --wait, assign it to yourself and add to team sycn under port management for JB. We need to fix it with help of JB.

Issue created.

• [JetBrains] Command gp open --wait doesn't exit when closing a file tab #10299