Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme selection components #10111

Merged
merged 2 commits into from
May 19, 2022
Merged

Update theme selection components #10111

merged 2 commits into from
May 19, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented May 18, 2022

Description

This will update the πŸ…°οΈ theme selection components with the new selectable component, as well as the πŸ…±οΈ illustrations used for the theme options. πŸŒ”

Thanks again @mustard-mh for introducing this new component in #8783! πŸ€

How to test

Go to /preferences and notice the new selectable card component.

Screenshots

BEFORE AFTER
theme-light-before theme-light-after
theme-dark-before theme-dark-after

Release Notes

Update theme selection components

@gtsiolis gtsiolis marked this pull request as ready for review May 18, 2022 22:40
@gtsiolis gtsiolis requested a review from a team May 18, 2022 22:40
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 18, 2022
@roboquat roboquat added size/M and removed size/S labels May 18, 2022
@gtsiolis gtsiolis force-pushed the gt/update-theme-options branch from 2c9cf8d to b82ec66 Compare May 18, 2022 22:58
@easyCZ
Copy link
Member

easyCZ commented May 19, 2022

/werft run

πŸ‘ started the job as gitpod-build-gt-update-theme-options.4
(with .werft/ from main)

@roboquat roboquat merged commit e57642d into main May 19, 2022
@roboquat roboquat deleted the gt/update-theme-options branch May 19, 2022 08:30
@gtsiolis
Copy link
Contributor Author

gtsiolis commented May 19, 2022

Thanks for taking a look @andrew-farries and @easyCZ! πŸ€

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants