[db] enable overriding of expiryDate on tokens #10102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
reviewed
May 18, 2022
Comment on lines
+345
to
+350
| if (latestTokenEntry) { | ||
| if (latestTokenEntry.expiryDate !== latestTokenEntry.token.expiryDate) { | ||
| log.info(`Overriding 'expiryDate' of token to get refreshed on demand.`, { identity }); | ||
| } | ||
| return { ...latestTokenEntry.token, expiryDate: latestTokenEntry.expiryDate }; | ||
| } |
There was a problem hiding this comment.
Nit: Would prefer single-level if / early return:
Suggested change
| if (latestTokenEntry) { | |
| if (latestTokenEntry.expiryDate !== latestTokenEntry.token.expiryDate) { | |
| log.info(`Overriding 'expiryDate' of token to get refreshed on demand.`, { identity }); | |
| } | |
| return { ...latestTokenEntry.token, expiryDate: latestTokenEntry.expiryDate }; | |
| } | |
| if (!latestTokenEntry) { | |
| return; | |
| } | |
| if (latestTokenEntry.expiryDate !== latestTokenEntry.token.expiryDate) { | |
| log.info(`Overriding 'expiryDate' of token to get refreshed on demand.`, { identity }); | |
| } | |
| return { ...latestTokenEntry.token, expiryDate: latestTokenEntry.expiryDate }; |
jankeromnes
approved these changes
May 18, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test
d_b_token_entrytable and set an older date (-1d) forexpiryDate./integrationspage.INFO: Token refreshed and updated.is logged in server.