Make the pods be removed when workspacekit fails.

[utam0k]

Description

There was a problem with workspace pendings due to finalizer not working properly when iws failed to start (or had a large delay). This PR avoids that by skipping the finalizer. Also, the workspace phase is now consistent with it.

Related Issue(s)

Fixes #9673

How to test

• workspaces can normally start. You can confirm this preview environment
• Intentionally break communication between iws and ws-daemon, and when a workspace failed to start, confirm that the workspace phase is properly stopped(NOTE: in this case, the stopping phase is skipped because we don't need to backup.) You can confirm it on this preview environment

Release Notes

ws-manager: Make the pods be removed when workspacekit fails.

Documentation

No

[csweichel]

Change makes sense.

Could you add a fixture to test this new behaviour: https://github.com/gitpod-io/gitpod/blob/main/components/ws-manager/pkg/manager/monitor_test.go#L20?

[utam0k]

Change makes sense.

Could you add a fixture to test this new behaviour: https://github.com/gitpod-io/gitpod/blob/main/components/ws-manager/pkg/manager/monitor_test.go#L20?

@csweichel
Thanks for your review. I took looked at the fixtures file but I couldn't find how to generate the golden and status json file. Can I ask you to tell me how to generate these fixtures file?

[sagor999]

@utam0k
To update golden files: run go test ./... -update -force from inside componets/ws-manager folder.
This will regenerate any golden files.
If you need to update what is inside golden files, then you edit corresponding json file and run the command from above to update golden file.

To add a new fixture, you would want to add a new json file that would test this new behaviour (look at existing ones as inspiration), and then run command above to generate golden file from that new json file.

Let me know if you need help with this.

[sagor999]

Adding myself as reviewer as Chris is OOO this week.

[utam0k]

@sagor999 PTAL

[utam0k]

@sagor999 @Furisto PTAL