-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSH connection analytics #10074
Add SSH connection analytics #10074
Conversation
@iQQBot Could you add a new event in https://www.notion.so/gitpod/Tracking-Plan-ed27d1492da745b9b31711dd73dcbe57 please, explain properties, phases and possible values? 🙏 |
@iQQBot Could we extract an improvement in another PR? I think the improvement is questionable and need to be discussed. Analytics though looks good already. I would like analytics parts get merged. |
@akosyakov @andreafalzetti Already do some cleanup, now this PR only include analytics for ssh connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you a lot!
Could you also add a metric for prometheus with another PR? I don't think we need to track duration of ssh connections, but having a counter of auth/connection attempts and success rate will be helpful. We don't need to label workspaces or collect any error information but only use it for monitoring and alerts. If we see a spike then we should go to logs and check them. |
Where do I verify the data? From segment.com? 🤔 |
Yes, login your account then find source |
Ok, no problem, just one point needs to be clarified, as a public network to expose the IP of port 22, is bound to be a variety of hackers violent crack every day, I suggest that the success rate of the statistics here should ignore the user name length of less than 6 digits |
Let's try without first? |
OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the installer side. Also, noting that this does not affect the self hosted user.
Description
This PR introduce SSH connection analytics in
ws-proxy
Related Issue(s)
Fixes #
How to test
ssh_connection
eventRelease Notes
Documentation