[public-api] Publish to NPM #10052
Merged
[public-api] Publish to NPM #10052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/public-api-publish-npm
branch
from
aa6d516 to
6348fe2
Compare
easyCZ
force-pushed
the
mp/public-api-publish-npm
branch
from
6348fe2 to
c887240
Compare
| "name": "@gitpod/public-api", | ||
| "version": "0.1.5", | ||
| "license": "UNLICENSED", | ||
| "files": [ | ||
| "client", |
There was a problem hiding this comment.
It didn't point to any actual files so no need to have it. It's only used for the publish.
| - components/gitpod-protocol:scripts | ||
| config: | ||
| commands: | ||
| - ["node", "components-gitpod-protocol--scripts/publish.js", "${version}", "components-public-api-typescript--lib/package"] |
There was a problem hiding this comment.
How is node able to find publish.js here (the components- don't look like valid paths?)
There was a problem hiding this comment.
I've no idea! This whole thing looks to be way more complicated than it needs to be but not really well placed to simplify. The code here just mirrors what supervisor-api does
| config: | ||
| packaging: library | ||
| dontTest: true | ||
| commands: | ||
| build: ["yarn", "build"] | ||
| yarnLock: ${coreYarnLockBase}/../yarn.lock | ||
| tsconfig: tsconfig.json | ||
|
|
||
| - name: publish |
There was a problem hiding this comment.
How is this triggered? We already have this:
Lines 81 to 89 in c887240
Does that need to be updated?
There was a problem hiding this comment.
Not sure, mirrors supervisor-api setup
andrew-farries
approved these changes
May 17, 2022
6 tasks
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Publish public-api typescript defs to NPM so they can be consumed by IDE.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
NONE