Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary skip the TestMissingBackup pvc test to make the integration test pass #10047

Merged
merged 1 commit into from
May 16, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented May 16, 2022

Description

As discussed in #8799 (comment), temporary skip the TestMissingBackup pvc test to make the integration test pass.

Related Issue(s)

Related to #9990

How to test

./dev/preview/install-k3s-kubeconfig.sh
cd test
go test -v ./... \
  -kubeconfig=/home/gitpod/.kube/config \
  -namespace=default \
  -run=TestMissingBackup

Result

...
=== RUN   TestMissingBackup
=== RUN   TestMissingBackup/CreateWorkspace
=== RUN   TestMissingBackup/CreateWorkspace/it_can_run_workspace_tasks
=== RUN   TestMissingBackup/CreateWorkspace/it_can_run_workspace_tasks/classic_backup_init
=== RUN   TestMissingBackup/CreateWorkspace/it_can_run_workspace_tasks/fwb_backup_init
=== CONT  TestMissingBackup/CreateWorkspace/it_can_run_workspace_tasks
    content_test.go:194: temporary skip the pvc test
--- PASS: TestMissingBackup (183.77s)
    --- PASS: TestMissingBackup/CreateWorkspace (183.77s)
        --- SKIP: TestMissingBackup/CreateWorkspace/it_can_run_workspace_tasks (183.77s)
            --- PASS: TestMissingBackup/CreateWorkspace/it_can_run_workspace_tasks/classic_backup_init (1.49s)
            --- PASS: TestMissingBackup/CreateWorkspace/it_can_run_workspace_tasks/fwb_backup_init (1.25s)

Release Notes

None

Documentation

N/A

@jenting jenting force-pushed the jenting/fix-broken-workspace-integration-9990 branch from f17c70b to d11565e Compare May 16, 2022 14:32
@jenting jenting marked this pull request as ready for review May 16, 2022 14:33
@jenting jenting requested a review from a team May 16, 2022 14:39
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 16, 2022
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you, @jenting ! Works as advertised.

@roboquat roboquat merged commit 2c7e144 into main May 16, 2022
@roboquat roboquat deleted the jenting/fix-broken-workspace-integration-9990 branch May 16, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants