[prebuilds] Fix prebuild updates received by ws-manager-bridge #10042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 16, 2022 09:04
…failed" state & test"" This reverts commit 6c4213e.
geropl
reviewed
May 16, 2022
| @@ -83,7 +83,7 @@ export class WorkspaceManagerBridgeEE extends WorkspaceManagerBridge { | |||
| if (update) { | |||
| const updatedPrebuild = { | |||
| ...prebuild, | |||
| ...update, | |||
| ...update.update, | |||
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Un-revert #9924 and fix the bug it introduced that caused no prebuild updates to be recorded for any prebuilds.
Many thanks to @laushinka for helping track this down.
Related Issue(s)
Fixes ##10008
How to test
Create a prebuild in this preview environment and see that it transitions through to READY rather than being stuck in PENDING.
Release Notes
Documentation
none