[ws-man-bridge] Add cluster role binding to scrape metrics #10034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+27
to
+35
| RoleRef: rbacv1.RoleRef{ | ||
| Kind: "ClusterRole", | ||
| Name: fmt.Sprintf("%s-kube-rbac-proxy", ctx.Namespace), | ||
| APIGroup: "rbac.authorization.k8s.io", | ||
| }, | ||
| Subjects: []rbacv1.Subject{{ | ||
| Kind: "ServiceAccount", | ||
| Name: Component, | ||
| Namespace: ctx.Namespace, |
There was a problem hiding this comment.
So we want to bind the ws-manager-bridge to the kube-rbac-proxy cluster role? Given the role's name, I'd assume that it is intended to have the only the kube-rbac-proxy service account bound to it.
andrew-farries
approved these changes
May 16, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ws-manager-bridge is not being scraped correctly due to missing cluster role binding, logs show:
This change adds the necessary role binding so that the
kube-rbac-proxysidecar can be scraped. This is the same as we do for other components, such asserver.Related Issue(s)
None
How to test
None
Release Notes
Documentation
NONE