Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions from .gitpod.yml are build run while it does not exist #9505

Closed
armanbilge opened this issue Apr 23, 2022 · 5 comments
Closed
Labels
component: server feature: prebuilds team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@armanbilge
Copy link

armanbilge commented Apr 23, 2022

Bug description

Opening a new workspace of my repo outputs:

 HISTFILE=/workspace/.gitpod/cmd-0 history -r; {
[ -r /workspace/.prebuild-log-0 ] && cat /workspace/.prebuild-log-0; [ -r /workspace/.gitpod/prebuild-log-0 ] && cat /workspace/.gitpod/prebuild-log-0; true
} && {
echo 'TODO: start app'

}
gitpod /workspace/schrodinger (main) $  HISTFILE=/workspace/.gitpod/cmd-0 history -r; {
> [ -r /workspace/.prebuild-log-0 ] && cat /workspace/.prebuild-log-0; [ -r /workspace/.gitpod/prebuild-log-0 ] && cat /workspace/.gitpod/prebuild-log-0; true
> } && {
> echo 'TODO: start app'
> 
> }
TODO: start app

However, there is no .gitpod.yml in my repo and there is no "Project" for this repo either.

Steps to reproduce

Open https://github.com/armanbilge/schrodinger/ in GitPod.

Workspace affected

No response

Expected behavior

.gitpod.yml should not be processed when it doesn't exist.
There should be no history -r in this situation, or at least there should be a way to disable it :)

Example repository

https://github.com/armanbilge/schrodinger/

Anything else?

Thanks to @pawlean and @axonasif for their support on Discord.

@axonasif axonasif changed the title history -r invoked when opening a new workspace Instructions from .gitpod.yml are build run while it does not exist Apr 23, 2022
@axonasif axonasif added feature: prebuilds team: workspace Issue belongs to the Workspace team type: bug Something isn't working team: webapp Issue belongs to the WebApp team labels Apr 23, 2022
@axonasif
Copy link
Member

Also, attempting to trigger manual prebuild results in:
image

@axonasif
Copy link
Member

axonasif commented Apr 23, 2022

It seems like I'm experiencing this too, my new changes on .gitpod.yml aren't being reflected on the resulting workspaces. So, for example, a task:command is being run on a terminal that I had removed on a git-commit before opening the repo, while at the same time, it does not exist on the .gitpod.yml file present inside my workspace.

Repo: https://github.com/axonasif/flutter-web/tree/axon/refactor_template
Workspace: axonasif-flutterweb-4pvpszfp1tt.ws-us42xl

@armanbilge
Copy link
Author

Update: I pushed a new commit to the main branch on my repo and the issue has gone away.

However, if you specifically create a workspace at the previous commit you can still reproduce the problem described in this issue.

https://github.com/armanbilge/schrodinger/tree/34f23cbe8e83f252d6157770fec083b006ae81cd

@geropl geropl added component: server and removed team: workspace Issue belongs to the Workspace team labels Apr 29, 2022
@geropl geropl moved this to Scheduled in 🍎 WebApp Team Apr 29, 2022
@CyriacBr
Copy link

CyriacBr commented May 3, 2022

I have this issue as well. I removed the default watch command from .gitpod.yml, committed then pushed the changes (to main), but that command is still ran whenever I open the pod.

@AlexTugarev
Copy link
Member

Hi @armanbilge! Thanks for reporting. We definitely need to improve the Project creation flow and messaging around it to get to a point, where things happening get clear.

What you've been seeing is a feature in Projects (#7383). Whenever you create a new project, and there is no .gitpod.yml found, Gitpod is automatically proposes a simple configuration to help you getting started with prebuilds.

Please see, that you have created a project in your personal account, https://gitpod.io/projects/schrodinger. I just checked with a fork of your repo.

Screen Shot 2022-05-20 at 09 14 01

cc. @jldec, @geropl

Repository owner moved this from Scheduled to Done in 🍎 WebApp Team May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: server feature: prebuilds team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

5 participants