Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set project root based on workspace context folder #6900

Open
corneliusludmann opened this issue Nov 25, 2021 · 8 comments
Open

Set project root based on workspace context folder #6900

corneliusludmann opened this issue Nov 25, 2021 · 8 comments
Labels
editor: jetbrains meta: never-stale This issue can never become stale team: IDE type: feature request New feature or request

Comments

@corneliusludmann
Copy link
Contributor

When you open a workspace with a folder in the context URL like this one:

https://gitpod.io/#https://github.com/gitpod-io/gitpod/tree/main/components/ide/jetbrains/backend-plugin

We currently start the IDE with /workspace/gitpod as project root that has the folder components/ide/jetbrains/backend-plugin unfolded in the tree view. It would be even more useful when we change this behavior to open this folder as project root in the editor instead.

This would be a good step towards better support for projects inside mono-repos, especially when there are different languages in one repo. E.g. this would allow to better index a project in the JetBrains IDE.

(internal discussions)

Note: This issue is not about handling .gitpod.yml files in subfolders and should be handled in a separate issue.


Technically, we could check if

echo $GITPOD_WORKSPACE_CONTEXT | jq -r .isFile

is false and if this is the case set

echo "$GITPOD_REPO_ROOT/$(echo $GITPOD_WORKSPACE_CONTEXT | jq -r .path)"

as project root for the editor. Maybe there is even a more elegant way to do this, e.g using supervisor API resp. gp info instead of env vars (see also #6803 (comment)).

@akosyakov
Copy link
Member

akosyakov commented Nov 26, 2021

I don't oppose it, since current folder context is not really useful. What surprised me though today that I cannot change a folder in IntelliJ which what actually devs do while working on mono repos or just checking out another repo. I think we need to clarify with JetBrains whether it would be possible from client to open another project or folder. If not I guess we will need to think about the solution in supervisor frontend/ready screen to allow picking the folder. Or maybe it can be addressed when we go away from code with me to own protocol.

@corneliusludmann
Copy link
Contributor Author

/schedule

@roboquat
Copy link
Contributor

roboquat commented Dec 2, 2021

@corneliusludmann: Issue scheduled in the IDE team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akosyakov akosyakov added the type: feature request New feature or request label Dec 6, 2021
@akosyakov
Copy link
Member

I removed it, since I don't think @corneliusludmann have capacity to work on it anymore.

@loujaybee
Copy link
Member

@stale
Copy link

stale bot commented Jun 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 11, 2022
@ChristianHuff-DEV
Copy link

In regards of the "stale" tag: For me this is still an issue preventing me from using Goland.

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jun 13, 2022
@ChristianHuff-DEV
Copy link

Relates to: https://youtrack.jetbrains.com/issue/CWM-4476

Looks like the issue was resolved and released. Can you share an estimate when someone is gonna take another look at this?

@akosyakov akosyakov removed this from 🚀 IDE Team Oct 7, 2022
@akosyakov akosyakov added the meta: never-stale This issue can never become stale label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor: jetbrains meta: never-stale This issue can never become stale team: IDE type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants