Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement analytics on git (git commit) #6896

Closed
loujaybee opened this issue Nov 25, 2021 · 9 comments · Fixed by #7463
Closed

Implement analytics on git (git commit) #6896

loujaybee opened this issue Nov 25, 2021 · 9 comments · Fixed by #7463
Assignees
Labels
aspect: analytics Anything related to analytics aspect: growth Issues relating to product growth initiatives editor: code (browser) team: IDE team: workspace Issue belongs to the Workspace team

Comments

@loujaybee
Copy link
Member

loujaybee commented Nov 25, 2021

Context: Tracking a git commit is a strong signal that a user is doing something "meaningful" in a workspace, and is useful as the "end" point for our onboarding funnel. A git commit signals that the user has understood things like: Gitpod is a container image, gitpod is mutable and not read-only (e.g. it's not just a https://vscode.dev/ type application), etc.


We currently don't know how/when users are discovering terminal access within the browser-based VS Code. This issue is to implement the potential tracking of terminal events within hosted VS Code.

Terminal events that are of particular interest are:

  • git commands, specifically git commit as this tells us when a user has acknowledged that Gitpod is not just a read-only application, and that full git workflows are possible.
  • install commands such as npm install or apt-get as we want to see if users are understanding that they can codify their installations into the .gitpod.yml or not, and whether they're utilising configurations such as prebuilds.

A technical spike might be required to understand how this could feasibly be implemented. Will also be worth getting the @gitpod-io/engineering-workspace team involved and @csweichel to hep us with this.

DISCLAIMER: We need to be careful with this to respect users privacy. Let's investigate what changes we'll need to make to our privacy policy, or possibly implement an explicit opt-in for users to send us developer data.

@loujaybee loujaybee added team: IDE team: workspace Issue belongs to the Workspace team editor: code (browser) aspect: analytics Anything related to analytics aspect: growth Issues relating to product growth initiatives labels Nov 25, 2021
@loujaybee loujaybee changed the title Implement analytics on terminal commands in VS Code Implement analytics on terminal commands (e.g. git) in VS Code Nov 30, 2021
@jeanp413
Copy link
Member

jeanp413 commented Dec 7, 2021

@loujaybee loujaybee changed the title Implement analytics on terminal commands (e.g. git) in VS Code Implement analytics on git commit Dec 8, 2021
@loujaybee loujaybee changed the title Implement analytics on git commit Implement analytics on git / git commit Dec 8, 2021
@loujaybee loujaybee changed the title Implement analytics on git / git commit Implement analytics on git (git commit) Dec 8, 2021
@loujaybee
Copy link
Member Author

Spoke with @akosyakov and have reduced the scope on this to be tracking only "git" commands, rather than all terminals.

@loujaybee
Copy link
Member Author

Is dependent upon: #7137

@loujaybee loujaybee added the meta: blocked in progress but blocked by upstream issues or missing data label Dec 14, 2021
@loujaybee
Copy link
Member Author

/schedule

@roboquat
Copy link
Contributor

@loujaybee: Issue scheduled in the workspace team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeanp413
Copy link
Member

jeanp413 commented Dec 15, 2021

From the vscode telemetry:

  • event name git.command for all commands in the git extension, it only logs the git command id, git commands executed from the terminal are not detected.

@akosyakov
Copy link
Member

We decided to go with tracking git push on credential helper level. Instrumenting git extensions will require maintaining another web socket connection to the server so we rather postpone it.

@akosyakov akosyakov removed groundwork: in progress meta: blocked in progress but blocked by upstream issues or missing data labels Dec 15, 2021
@bigint
Copy link

bigint commented Dec 16, 2021

So is this gonna be an anonymous data collection or do you collect user's data (example: ws id)?

@loujaybee
Copy link
Member Author

loujaybee commented Dec 20, 2021

Hey @bigint ! Thanks for asking such an important question 😄

Let's move that conversation to this issue: #7317 (comment) as we may need to make some changes to our privacy policy, etc, (e.g. allowing users to opt-in/opt-out of sending telemetry data). From our side, we need some data to better understand how folks are using Gitpod, so that we can do a better job with the product, but we 100% respect our users privacy, and we will be looking into what (if any) legal changes we'll need to make 🙏 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: analytics Anything related to analytics aspect: growth Issues relating to product growth initiatives editor: code (browser) team: IDE team: workspace Issue belongs to the Workspace team
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

6 participants