-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update team selection design for onboarding flow #6686
Comments
Thanks for those designs @gtsiolis - I took the liberty of listing the rough edges I saw in the existing page and adding a screenshot in the description above. |
@gtsiolis, please let me know if you have questions about the list I added to the issue desciption above. |
@jldec I think points [2], [3], and [4] are partially or fully addressed with the proposal in the issue description, right? Currently, |
I would say 2, 3, 4 are all more important than 1 |
Another interesting idea (credit @svenefftinge) to reduce the amount of cognitive load required from users: How about providing a default selection/name (and offer a simpler [continue] button) so that you can get through this page without necessarily making a conscious selection decision. The proposed default would be:
|
FWIW I think we could stay with the current design if we just make the |
Here is what I think is the simplest possible fix here: #6966 In summary:
Happy to discuss tomorrow! 🙂 |
Relates to: #6969 |
Notes from sync with @jankeromnes and @gtsiolis
Additional behaviors for defaults will require a separate issue and PR - possible inputs for default behavior are
Note that the dashboard context is not available when the /new flow is initiated from outside the dashboard |
/schedule |
@jldec: Issue scheduled in the meta team (WIP: 0) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
Problem to solve
The Select Team step in the New Project onboarding flow contains some rough edges.
In the example below, a user "John Smith" (user-id gptest1) has selected the "website" repo on the left. The next step is the page outlined in grey on the right.
The repo was selected in the previous step, but the 2nd line still says "Select a Git repository on github.com (change)". It would be nice to see where you are in the flow.
When this is a new user, there is no existing team to select. The actual choices are either to create a new team, or to skip team creation and add the new project under your personal account. It would help to make this explicit.
Showing just the name of a personal account can be confusing, since that is not recognizable as a choice of "team".
Without hovering, there is no visual indication that the personal account name
John Smith
is one of the two (selectable) options.The current design is also using unnecessary borders and lacks some labels for differentiating the personal account from team entries.
Proposal
Splitting the designs from #4951 into a smaller MVC issue that contains updated designs specs and focuses solely on the omnboarding flow, let's update the team selection design for onboarding flow.
This does not take into account any changes that are needed for the header section of the onboarding flow but focuses on the team selection elements. 💡
This approach also removed the buttons, re-using the same pattern used elsewhere in modals for parallel workspaces, limits reached, and more.
See relevant specs (WIP).
The text was updated successfully, but these errors were encountered: