Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update team selection design for onboarding flow #6686

Closed
gtsiolis opened this issue Nov 12, 2021 · 12 comments · Fixed by #7030
Closed

Update team selection design for onboarding flow #6686

gtsiolis opened this issue Nov 12, 2021 · 12 comments · Fixed by #7030
Assignees
Labels
component: dashboard deployed Change is completely running in production feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. needs visual design team: webapp Issue belongs to the WebApp team user experience

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 12, 2021

Problem to solve

The Select Team step in the New Project onboarding flow contains some rough edges.

In the example below, a user "John Smith" (user-id gptest1) has selected the "website" repo on the left. The next step is the page outlined in grey on the right.

Screenshot 2021-11-12 at 20 29 35

  1. The repo was selected in the previous step, but the 2nd line still says "Select a Git repository on github.com (change)". It would be nice to see where you are in the flow.

  2. When this is a new user, there is no existing team to select. The actual choices are either to create a new team, or to skip team creation and add the new project under your personal account. It would help to make this explicit.

  3. Showing just the name of a personal account can be confusing, since that is not recognizable as a choice of "team".

  4. Without hovering, there is no visual indication that the personal account name John Smith is one of the two (selectable) options.

The current design is also using unnecessary borders and lacks some labels for differentiating the personal account from team entries.

Proposal

Splitting the designs from #4951 into a smaller MVC issue that contains updated designs specs and focuses solely on the omnboarding flow, let's update the team selection design for onboarding flow.

This does not take into account any changes that are needed for the header section of the onboarding flow but focuses on the team selection elements. 💡

This approach also removed the buttons, re-using the same pattern used elsewhere in modals for parallel workspaces, limits reached, and more.

Team Selection
TeamSelection

See relevant specs (WIP).

@gtsiolis gtsiolis added user experience component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team labels Nov 12, 2021
@jldec
Copy link
Contributor

jldec commented Nov 15, 2021

Thanks for those designs @gtsiolis - I took the liberty of listing the rough edges I saw in the existing page and adding a screenshot in the description above.

@jldec jldec moved this to In Groundwork in 🍎 WebApp Team Nov 16, 2021
@jldec
Copy link
Contributor

jldec commented Nov 18, 2021

@gtsiolis, please let me know if you have questions about the list I added to the issue desciption above.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 18, 2021

@jldec I think points [2], [3], and [4] are partially or fully addressed with the proposal in the issue description, right?

Currently, 🅰️ exploring ways to improve these issues using the existing proposal and 🅱️ thinking how we can resolve the first point regarding the misleading header and flow phase indicator. Let's meet when I'm back next week and sketch together. What do you think?

@jldec
Copy link
Contributor

jldec commented Nov 25, 2021

I would say 2, 3, 4 are all more important than 1
It would be good to address those explicitly.

@jldec
Copy link
Contributor

jldec commented Nov 25, 2021

Another interesting idea (credit @svenefftinge) to reduce the amount of cognitive load required from users:

How about providing a default selection/name (and offer a simpler [continue] button) so that you can get through this page without necessarily making a conscious selection decision.

The proposed default would be:

  • select the personal account for personal repos
  • select new team, pre-populated with the same name as the org, for org-owned repos

@svenefftinge
Copy link
Member

FWIW I think we could stay with the current design if we just make the Continue button on the individual account always visible and prefill the team with the name of the org (adding a number, when there's a conflict).
Also, I too would be in favor of skipping the entire step when a user imports a personal project.

@jankeromnes
Copy link
Contributor

jankeromnes commented Nov 29, 2021

Here is what I think is the simplest possible fix here: #6966

In summary:

  • When clicking on New Project from a specific team, we don't ask (unchanged)
  • When clicking on New Project from your personal account, we don't ask (new with above PR)
  • When visiting /new without context, we ask under which team or personal account to create the Project (unchanged)

Happy to discuss tomorrow! 🙂

@loujaybee
Copy link
Member

Relates to: #6969

@jldec
Copy link
Contributor

jldec commented Nov 30, 2021

Notes from sync with @jankeromnes and @gtsiolis

  • Decision is to use a single-click in-list selection model (A) instead of 2-step select + [Continue] (B)
  • Each list item has a small indicator to help users understand that it is selectable (part of the list) and shows the selection state.
  • List items can be selected without any button showing on hover
  • The last item "New Team" can show an input with dropdown (just like today)

choice of list selection models

Additional behaviors for defaults will require a separate issue and PR - possible inputs for default behavior are

  1. project repository context - org/repo or user/repo
  2. dashboard context - top level (personal) vs team

Note that the dashboard context is not available when the /new flow is initiated from outside the dashboard

@jankeromnes jankeromnes self-assigned this Nov 30, 2021
@jldec
Copy link
Contributor

jldec commented Nov 30, 2021

/schedule

@roboquat
Copy link
Contributor

@jldec: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jankeromnes jankeromnes removed their assignment Dec 1, 2021
@jankeromnes
Copy link
Contributor

/assign

@gtsiolis gtsiolis self-assigned this Dec 2, 2021
Repository owner moved this from In Groundwork to Done in 🍎 WebApp Team Dec 6, 2021
@jldec jldec added deployed Change is completely running in production and removed groundwork: awaiting deployment labels Dec 7, 2021
@jldec jldec moved this to Done in 🍎 WebApp Team Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard deployed Change is completely running in production feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. needs visual design team: webapp Issue belongs to the WebApp team user experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants