Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] streamline terminal integration #5620

Closed
akosyakov opened this issue Sep 9, 2021 · 2 comments · Fixed by #5633
Closed

[code] streamline terminal integration #5620

akosyakov opened this issue Sep 9, 2021 · 2 comments · Fixed by #5633

Comments

@akosyakov
Copy link
Member

We spent a lot of time in the past to align our terminal implementation to work again supervisor instead we would like to use the default implementation from web-server. The following steps:

  • remove our implementation and hook in web-server implementation
  • move task terminals from gitpod-remote to gitpod-shared and enable for both remote and web targets
  • there was a new proposed terminal API which allow to layout them, we should make use of it to layout task terminals properly.
@akosyakov
Copy link
Member Author

/schedule

@roboquat
Copy link
Contributor

roboquat commented Sep 9, 2021

@akosyakov: Issue scheduled in the IDE team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants