[image-builder] mkIII: imagebuild workspaces seem to ignore "workspace templates"

[geropl]

While testing #5480 I was blocked because an imagebuild got scheduled to a NodePool where no suitable ws-daemon was running (context: #5432).

On inspection of the imagebuild it did not contain a nodeAffinity, but the workspace-template ConfigMap did:

• not for default
• but for all specific workspace types (incl. imagebuild)

I did not have time to investigate further. This should be easily reproduceable by triggering an image build in a preview env. (note that you might get lucky and the build succeeds if the workspaces ends up on the "right" node. Please check the pods yaml to verify that there's no nodeAffinity).

[csweichel]

/team workspace

[csweichel]

/schedule

[roboquat]

@csweichel: Issue scheduled in the workspace team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csweichel]

An additional cdwp fixture test(see create_test.go) could also be used to verify this. Looks like we're missing the case for image-builds though.

[csweichel]

/assign