Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reintroduce partial clone #5231

Closed
akosyakov opened this issue Aug 17, 2021 · 7 comments · Fixed by #6464
Closed

reintroduce partial clone #5231

akosyakov opened this issue Aug 17, 2021 · 7 comments · Fixed by #6464
Assignees
Labels
aspect: performance anything related to performance groundwork: awaiting deployment team: workspace Issue belongs to the Workspace team

Comments

@akosyakov
Copy link
Member

See #5152

We should reintroduce it in such way that it does not break forking and blaming.

@akosyakov akosyakov added the aspect: performance anything related to performance label Aug 17, 2021
@JanKoehnlein
Copy link
Contributor

Though I am convinced improving performance is important, I think we should ATM focus on issues that increase stability instead. Feel free to bring this up at a later point in time.

If you have any particular idea how to avoid the prior pitfalls, don't hesitate to add them to this issue. The clearer the path to a solution the more likely it will be scheduled.

@akosyakov
Copy link
Member Author

It seems the load timing is significantly high now. If it is the reason I think we should assign someone to investigate. I don't think the solution will appear othewise.

@svenefftinge
Copy link
Member

We should allow people to opt-in through the repository configuration on how a clone should happen.
I think it makes sense to allow general clone arguments. So people can use different kinds of clones. Also we might want to investigate if a shallow clone followed by an async inflation that happens when users are already on the workspace couel make sense. this could drastically reduce the size on the file system for prebuild snapshots as well.

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 25, 2021

An option to select partial clone, full clone, or clone using arguments could be something to consider adding in a projects settings area, next to features like project-level environment variables #4456. 💭

Also we might want to investigate if a shallow clone followed by an async inflation that happens when users are already on the workspace couel make sense.

This also sounds interesting!

@csweichel csweichel added the team: workspace Issue belongs to the Workspace team label Oct 31, 2021
@csweichel
Copy link
Contributor

/schedule

@roboquat
Copy link
Contributor

@csweichel: Issue scheduled in the workspace team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csweichel
Copy link
Contributor

/assign @aledbf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: performance anything related to performance groundwork: awaiting deployment team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants