Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-revert and fix additionalEmails / commit email feature #4815

Closed
corneliusludmann opened this issue Jul 14, 2021 · 5 comments
Closed

Re-revert and fix additionalEmails / commit email feature #4815

corneliusludmann opened this issue Jul 14, 2021 · 5 comments
Labels
meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team type: feature request New feature or request

Comments

@corneliusludmann
Copy link
Contributor

We reverted the additionalEmails feature in the PR #4797 due to the DB migration that renames a column. In order to get this feature back in main we need to agree on how we would migrate the DB instead (e.g. adding a new column instead). The goal is that the old server is still compatible with the new DB scheme.

@corneliusludmann corneliusludmann added the type: feature request New feature or request label Jul 14, 2021
@csweichel
Copy link
Contributor

/schedule

@corneliusludmann
Copy link
Contributor Author

#4890 should be done first.

@csweichel csweichel added the team: webapp Issue belongs to the WebApp team label Aug 24, 2021
@corneliusludmann
Copy link
Contributor Author

/dont-schedule

Un-schedule this for now since we cannot work on this until the MySQL upgrade has been performed.

@roboquat
Copy link
Contributor

roboquat commented Sep 2, 2021

@corneliusludmann: Cannot schedule issue - no configuration for the meta team available.

In response to this:

/dont-schedule

Un-schedule this for now since we cannot work on this until the MySQL upgrade has been performed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale
Copy link

stale bot commented Dec 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 1, 2021
@stale stale bot closed this as completed Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants