Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard does not load on Safari < 14 #4068

Closed
akosyakov opened this issue Apr 26, 2021 · 0 comments · Fixed by #4069
Closed

dashboard does not load on Safari < 14 #4068

akosyakov opened this issue Apr 26, 2021 · 0 comments · Fixed by #4069
Assignees
@akosyakov
Labels
component: dashboard type: bug Something isn't working

Comments

@akosyakov
Copy link
Member

akosyakov commented Apr 26, 2021 •
edited
Loading

Bug description

MediaQueryList inherits EventTarget only from Safari 14. Currently all browsers implement addListener and removeListener already. see https://developer.mozilla.org/en-US/docs/Web/API/MediaQueryList We should use it for now.

Steps to reproduce

See above.

Expected behavior

No response

Example repository

No response

Anything else?

No response
@akosyakov akosyakov self-assigned this Apr 26, 2021
@akosyakov akosyakov added component: dashboard type: bug Something isn't working labels Apr 26, 2021
@akosyakov akosyakov added this to the April 2021 milestone Apr 26, 2021
@akosyakov akosyakov mentioned this issue Apr 26, 2021
Merged
akosyakov added a commit that referenced this issue Apr 26, 2021
@akosyakov
[dashboard] fix #4068: load on Safari < 14
c061659
akosyakov added a commit that referenced this issue Apr 26, 2021
@akosyakov
[dashboard] fix #4068: load on Safari < 14
babf0a4
MatthewFagan pushed a commit to trilogy-group/gitpod that referenced this issue Aug 9, 2021
@akosyakov
[dashboard] fix gitpod-io#4068: load on Safari < 14
81429dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
component: dashboard type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dashboard] load on Safari < 14 gitpod-io/gitpod
1 participant
@akosyakov