Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] Remove "machine resources" when deleting a workspace #3277

Closed
akosyakov opened this issue Feb 26, 2021 · 4 comments · Fixed by #4778
Closed

[code] Remove "machine resources" when deleting a workspace #3277

akosyakov opened this issue Feb 26, 2021 · 4 comments · Fixed by #4778
Assignees
@akosyakov
Labels
editor: code (browser) roadmap item: gitpod code https://bit.ly/3oqjuOn type: work item This issue pertains to something we have to do where the result is not code or a deployed feature
Milestone
[backlog] June 2021

Comments

@akosyakov
Copy link
Member

A user can see a list of all synchronised machines (workspaces) in Code which grows infinitely with each new workspace. We should make sure that a machine gets removed as soon as an associated workspace is deleted.
@akosyakov akosyakov added this to the March 2021 milestone Feb 26, 2021
@akosyakov
Copy link
Member Author

We should figure out how to associated a machine with the workspace, right now the view is not very helpful. We also don't need to persist old revisions for this resource, a user never sees them and cannot rollback.

@csweichel csweichel changed the title code: remove GC workspaces from machines user resources [code] Remove "machine resources" when deleting a workspace Mar 1, 2021
@csweichel csweichel added roadmap item: gitpod code https://bit.ly/3oqjuOn type: work item This issue pertains to something we have to do where the result is not code or a deployed feature labels Mar 1, 2021
@csweichel csweichel modified the milestones: March Backlog 2021, [do-not-add-issues] March 2021 Mar 1, 2021
@csweichel csweichel assigned jankeromnes and akosyakov and unassigned jankeromnes Mar 4, 2021
@akosyakov akosyakov modified the milestones: March 2021, [backlog] April 2021 Mar 29, 2021
@akosyakov akosyakov added the priority: 💪 stretch goal This issue is a stretch goal within an iteration. label Apr 13, 2021
@csweichel csweichel removed this from the April 2021 milestone May 6, 2021
@akosyakov akosyakov added this to the [backlog] June 2021 milestone Jun 7, 2021
@akosyakov akosyakov removed the priority: 💪 stretch goal This issue is a stretch goal within an iteration. label Jun 29, 2021
@akosyakov
Copy link
Member Author

It is going to become a problem sooner or later. The only way for a user then will be to reset all settings to clean up data. There is no way to clean up only machine resources.

@akosyakov
Copy link
Member Author

akosyakov commented Jul 12, 2021 •
edited
Loading

I tried to create such situation by decreasing payload length for machines resource and it silently breaks user data sync by delaying next sync each time more and more.

@akosyakov
Copy link
Member Author

akosyakov commented Jul 12, 2021 •
edited
Loading

I'm not sure what we can do about it right now. I opened an issue in upstream for now to represent machines better and control their lifecycle: microsoft/vscode#122652

As a workaround for time being we can remove all machines, but current or oldest and try again on 413 status code.

@akosyakov akosyakov mentioned this issue Jul 13, 2021
Merged
1 task
akosyakov added a commit that referenced this issue Jul 13, 2021
@akosyakov
[code] workaround #3277 by removing the oldest machine on too large p…
47a6a15 
…ayload
akosyakov added a commit that referenced this issue Jul 14, 2021
@akosyakov
[code] workaround #3277 by removing the oldest machine on too large p…
dfd139c 
…ayload
akosyakov added a commit that referenced this issue Jul 15, 2021
@akosyakov
[code] workaround #3277 by removing the oldest machine on too large p…
c060c81 
…ayload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
editor: code (browser) roadmap item: gitpod code https://bit.ly/3oqjuOn type: work item This issue pertains to something we have to do where the result is not code or a deployed feature
Projects
None yet
Milestone
[backlog] June 2021
Development

Successfully merging a pull request may close this issue.

[code] remove oldest machine resources on max payload error gitpod-io/gitpod
3 participants
@jankeromnes @akosyakov @csweichel