Please add some onbeforeunload handler in the workspace view to avoid unexpected tab exit

[erikmd]

Is your feature request related to a problem? Please describe

Currently using Gitpod in the browser is annoying when (like me) the Ctrl+w shortcut is wired in my hands, both in emacs and shell context…

Indeed, this closes the window.

Beyond my particular case, I believe many users also get annoyed when they mistype Ctrl+w and close their workspace tab.

Describe the behaviour you'd like

As suggested in #17724 (comment)

I would like to request some closing confirmation in all Gitpod browser editors,
→ with some JS code such as window.onbeforeunload = function(e) {e.preventDefault(); return false;}

and just undo this setting at workspace stop (e.g. gp stop, leading to page Stopped / Go-to-Dashboard)
→ with some JS code such as window.onbeforeunload = null;

Describe alternatives you've considered

One might otherwise try to disable the Ctrl+w shorcut in the browser, however as noted in
#17724 (comment)
this is neither browser-cross-compatible nor builtin in general, one needs to install 3rd-party extensions to do this.

So, adding an onbeforeunload handler looks way simpler, and fully works.

Additional context

N/A

[akosyakov]

VS Code already does it by default. If you want to have it always please change your settings "application.confirmExit": "always" otherwise it happens only for dirty changes.

[erikmd]

Dear @akosyakov,

Sorry but I'm not a VS code user 😅

I only use Gitpod's Browser Terminal (currently in beta IIUC) as a Gitpod IDE.

Is this confirmExit option available as well for all Gitpod web editors (other than VS code)?

[erikmd]

So I believe you could reopen this issue :)

[akosyakov]

Sorry, yes makes sense, we should support something like that there.

[erikmd]

Dear @akosyakov, do you know:

1. what could be the ETA for this improvement? (which will be important for Browser Terminal users IMHO)
2. did you already set a date for ending the Beta/releasing the Browser Terminal editor?

Sorry if this is not the proper place to ask…

[erikmd]

Dear Gitpod maintainers,

2. did you already set a date for ending the Beta/releasing the Browser Terminal editor?

I guess you already replied to this one, thanks for the release 👍 ❗ 🙏

What about the second question?

1. what could be the ETA for this improvement Please add some onbeforeunload handler in the workspace view to avoid unexpected tab exit #18416 ? (which will be important for Browser Terminal users IMHO)

Cc @loujaybee @akosyakov

Cheers,
Erik

[erikmd]

Thanks @loujaybee for adding this label :)

— Actually I noticed the issue with emacs, so maybe it could be tagged editor: emacs as well?

Thanks for your time!

[erikmd]

Dear @loujaybee,

Do you think this would help if I'd try to open a PR to implement this small (but very useful IMHO) enhancement?

Of course, I might need a bit of guidance at first, to spot the main components to change…

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[erikmd]

Hi! Please do not close, I do think this feature request is worth implementing.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[erikmd]

Please do not close, this feature request should definitely be addressed! Feel free to start implementing it, otherwise I may try to open a PR in a couple of weeks.

[filiptronicek]

Good news! As of later today, you'll be able to set the XTERM_CONFIRM_BROWSER_EXIT environment variable to true to always get prompted before closing the tab.

This can be done in your user variables to apply to all projects, on a repository configuration to apply to just one repository or by other means like adding the environment variable to the workspace Docker image itself.