Epic: Always Create Workspace with Options

[svenefftinge]

Gitpod used to do the-right-thing™️ based on context URLs. I.e. if you throw a PR link at it it will checkout the corresponding branch, if it's an issue it will create a new branch, etc. This was cool and a bit magical (in both good and bad ways), but has become less good, with the variability we have introduced (workspace classes, editor, env variables, etc.).

Therefore we have introduced a start-with-options dialog that allows users to review and change the input parameters to a create-workspace call. So far you have to explicitly pass an argument to get that dialog, but we believe the dialog is helpful to communicate and have users approve how a workspace is created.

Always showing the create workspace dialog also allows for communicating under which organization the workspace is going to be started.

Proposal

Show the create workspace dialog by default to all workspace creation requests unless there is an explicit argument to skip it (i.e. turn the logic around). Do the context URL parsing to fill the dialog with information about what is going to happen, specifically what repo and branch the workspace is going to be started with. Allow users to change that and confirm.

Breakdown

Bugs

Preview Give feedback

1. Allow workspace configuration on restarts #16998
   meta: stale team: webapp type: bug +3
2. Surface missing git integration on the new new workspace flow #16977
   component: dashboard needs visual design team: webapp type: bug +4
   
3. StartWorkspaceWithOptions: invalid URL error on missing scheme #17016
   component: dashboard component: server meta: stale type: bug +4
4. StartWorkspaceWithOptions: account validation not shown (error code 411) #17076
   component: dashboard component: server type: bug +3
   

[gtsiolis]

+1 — Re-posting a relevant part from #15756 (comment) for visibility:

Alternatively, we could skip the step to select options when directly selecting a workspace from the workspaces list using the row or workspace ID, and keep the prompt in all other cases like:

1. Workspace more actions dropdown
2. Project cards more action dropdown
3. Project branches new workspace button
4. Prebuild new workspace button

[mbrevoort]

This comment is very much related to this proposal

I believe that if a user ever starts or restarts, regardless of where they comes from, they should see a consistent and reliable interface. It should serve as:

1. a confirmation of what is about to happen
2. an opportunity to modify the parameters (editor, workspace class, etc.)
3. an opportunity to cancel

I don't believe we need additional options in menus like "Open with options" or "Open ...". There should just be "Open" and this unified experience.

[geropl]

Moved to here: https://linear.app/gitpod/issue/WEB-69/startworkspacewithoptions-account-validation-not-shown-error-code-411