Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce start with options on the workspaces list #15756

Closed
gtsiolis opened this issue Jan 16, 2023 · 2 comments
Closed

Introduce start with options on the workspaces list #15756

gtsiolis opened this issue Jan 16, 2023 · 2 comments
Labels
component: dashboard team: IDE type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

Following up from #15668, opening existing workspaces with a different editor is still a friction as it remains a user preference you have to change every time.

Cc @svenefftinge because #15567
Cc @loujaybee because #13580

Proposal

From the relevant discussions[1][2] (internal):

Now that start with options is available on projects and branches lists (#15668) could it make sense to also replace the Open menu on the workspace more actions context menu with Open … and prompt user to select a different editor when re-opening an existing workspace?

Screenshot 2023-01-13 at 4 33 16 PM

@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team team: IDE and removed team: webapp Issue belongs to the WebApp team labels Jan 16, 2023
@mbrevoort
Copy link
Contributor

I believe that if a user ever starts or restarts, regardless of where they comes from, they should see a consistent and reliable interface. It should serve as:

  1. a confirmation of what is about to happen
  2. an opportunity to modify the parameters (editor, workspace class, etc.)
  3. an opportunity to cancel

I don't believe we need additional options in menus like "Open with options" or "Open ...". There should just be "Open" and this unified experience.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jan 23, 2023

... they should see a consistent and reliable interface.

This sounds like a good MVC forward and provides more robust user control and freedom. It's also aligned with our product design principles[1]: Less choices, more control[1][2][3].

This is probably also easier to implement now that #15914 (Cc @selfcontained) has landed, see relevant comment in #6874 (comment):

Using the default options can be done by only using the showOptions parameter.

https://gitpod.io/?showOptions=true#https://github.com/gitpod-io/gitpod

☝️ This means, we could replace all workspace start URLs with prefixing with ?showOptions=true# and users will always get prompted to select the other options.


One small downside in terms of usability with this approach could be that this will always require at least two clicks instead of one for users to open a workspace, but sounds like the trade-off could be worth it.

Alternatively, we could skip the step to select options when directly selecting a workspace from the workspaces list using the row or workspace ID, and keep the prompt in all other cases like:

  1. Workspace more actions dropdown
  2. Project cards more action dropdown
  3. Project branches new workspace button
  4. Prebuild new workspace button

I'll close this in favor of #15979 (Cc @svenefftinge) as it already mentions the ability for the exception:

Show the create workspace dialog by default to all workspace creation requests unless there is an explicit argument to skip it (i.e. turn the logic around).

Thanks for the feedback, @mbrevoort! 🏀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: IDE type: improvement Improves an existing feature or existing code
Projects
Status: In Validation
Development

No branches or pull requests

2 participants