Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch gitpod team (eating your own dog food) to using PVC - regular workspaces only #10886

Closed
Tracked by #7901
sagor999 opened this issue Jun 23, 2022 · 10 comments
Closed
Tracked by #7901
Assignees

Comments

@sagor999
Copy link
Contributor

No description provided.

@sagor999
Copy link
Contributor Author

@kylos101 I would like to switch gitpodders to using PVC feature on Monday (June 27th)
That would be only for new workspaces. (will not apply to prebuilds)

@sagor999 sagor999 self-assigned this Jun 23, 2022
@sagor999 sagor999 moved this to In Progress in 🌌 Workspace Team Jun 23, 2022
@aledbf
Copy link
Member

aledbf commented Jun 24, 2022

I would like to switch gitpodders to using PVC feature on Monday (June 27th)

Not in SaaS right?

@sagor999
Copy link
Contributor Author

In SaaS indeed. I assume you have objections? @aledbf
That would enable the part where when you start a new workspace, it will use PVC and load any prior data from GCS.
But not enabled for prebuilds, since that PR is not merged yet.

@aledbf
Copy link
Member

aledbf commented Jun 24, 2022

In SaaS indeed. I assume you have objections? @aledbf

I think it is too risky to do it that way. I think it would be better to use a workspace class, meaning a separated node pool. Then, in case of any issue, the blast radius is limited to only a few nodes running only PVC workspaces from the team.

The problem with that idea is that we need to wait for Thomas work on workspaces classes :(

@sagor999 sagor999 moved this from In Progress to Scheduled in 🌌 Workspace Team Jun 27, 2022
@sagor999
Copy link
Contributor Author

Not entirely agree on it being too risky.
If anything, there is much less dependence on ws-daemon with PVC approach. So if anything, it should be more reliable, considering that ws-daemon crashes often.
Waiting for workspace classes will delay PVC roll out even longer.

@kylos101 kylos101 moved this from Scheduled to Backlog in 🌌 Workspace Team Aug 1, 2022
@kylos101 kylos101 removed the status in 🌌 Workspace Team Aug 5, 2022
@kylos101
Copy link
Contributor

kylos101 commented Aug 5, 2022

Removing from scheduled work for now (as you and JenTing are largely testing in ephemeral clusters, and will test later, probably gen61, with dedicated nodes).

@jenting jenting moved this to In Progress in 🌌 Workspace Team Aug 26, 2022
@kylos101
Copy link
Contributor

kylos101 commented Aug 31, 2022

👋 @sagor999 ,

We're really close, just a few hurdles, I think, till we can ship reliably with PVC! 🙌

What work remains before we can dog food PVC with regular workspaces? I'm aware of the below. Is there anything missing or that I shared incorrectly? I ask so that we can leverage workspace teammates to help deliver and ship as part of gen64. 🤝

Loadgen
Today, we got workspaces running with loadgen, but, that left us with some questions and changes to make.

  1. Fixes to support PVC on loadgen and integration test #12560

Integration tests
@jenting is starting to add basic support for PVC in our tests, I shared a comment as a guiding thought to help limit scope in the below issue.

  1. [integration tests] add regular workspace PVC integration test from PVC test plans #12497

Questions

  1. Do we still need chown for workspaces using PVC? May I ask you to track in a separate issue? This is something I think we can track and resolve in a separate issue but, isn't necessarily needed for dog fooding.
  2. Is this issue still valid, or can we close now? [PVC] When using PVC some files in .git folder have root ownership instead of gitpod #12527

@kylos101
Copy link
Contributor

@sagor999 may I ask you to create an issue to track whether chown can be removed for PVC, and add it to the epic as a day 2 item? I say this because I am skeptical we can remove for PVC "now".

For now, it seems like it depends whether the git content init was done from a prebuild versus a regular workspace. Example.

@sagor999
Copy link
Contributor Author

@kylos101 done: #12892

@kylos101
Copy link
Contributor

@sagor999 gonna close this issue, as there are no PRs linked to it, and we're using the Notion doc to plan release deploys/release.

Repository owner moved this from In Progress to Awaiting Deployment in 🌌 Workspace Team Sep 22, 2022
@kylos101 kylos101 moved this from Awaiting Deployment to Done in 🌌 Workspace Team Sep 24, 2022
@kylos101 kylos101 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2022
Repository owner moved this from Done to Awaiting Deployment in 🌌 Workspace Team Sep 24, 2022
@kylos101 kylos101 moved this from Awaiting Deployment to Done in 🌌 Workspace Team Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants