-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Self-Hosted Telemetry With Customer ID #10183
Comments
Potential follow up - write a docs page about this. |
Regarding sending the license ID vs. adding a custom customer field to the license:
In my opinion, both a custom field and license ID would work. The license ID is just there, with a custom field we have more flexibility. Technically, I would tend to a custom field but and the end of the day the customer success team has to manage the custom IDs when we decide on this and I don't know how practical it is for them. (copied from internal discussion) |
@jakobhero what would be your preferred implementation here? Might be easiest for us to jump on a call to quickly discuss the options here :) |
Quick FYI that @MircoatGitpod gave his 👍 from a GDPR and privacy policy perspective. |
hi @lucasvaltl, thanks for bringing this to my attention! using the license ID seems like a reasonable path here that i would assume would be perceived as the least intrusive from a customer's perspective. here are some thoughts for the implementation:
i would also be happy with the custom customer field approach: tracking-wise, it would not pose any issues, but i cannot comment on how much effort it would require to make the according changes in the product so that the customer data would be available when the tracking call is made and whether it would make sense to have it available at that time. happy to jump on a quick call find the optimal solution anytime! |
Thanks for the very detailed analysis @jakobhero! I've checked with our customer experience team, and the added effort here seems negligible. @corneliusludmann what do you think is the implementation cost/complexity of the custom field approach? |
Technically, there is no difference in the implementation whether we send the license ID or a custom field via telemetry. |
There is no webhook support. |
Understood! Thanks for the estimate @corneliusludmann. I also spoke with Julia and she is ok with the added effort of filling in the custom field when creating a license. Given the need to do extra work on the data side (scrape replicated's API) & just the added effort of having to use a secondary table to find customer names whenever this data is used, I think it is net beneficial to go with the custom field :) Please lmk if you disagree! |
Copying this conversation from a meeting with @mrsimonemms; Creating and using a custom Customer ID field is a bit more involved than originally anticipated due to limitations in the Gitpod legacy licenses. The legacy license payload is a struct that doesn't support arbitrary key/value pairs, and we've built the replicated license on top of top of the gitpod license struct. Adding either a @mrsimonemms did this adequately cover our conversation? |
That sounds so serious. What is the issue with adding a new field
to the struct that is empty by default (and will be set for Replicated license only)? What kind of backwards compatibility issue are you worry about? |
Adding that single field will definitely work and is likely the fastest solution. My thinking is how flexible do we need to make this - does it make sense to support arbitrary key/value pairs to reflect the flexibility of replicated licensing? Though, thinking on the shipping skateboard principle, adding a |
Ah, now I see your point. I think we don't need that flexibility, and adding the single field is fine. 👍 |
Is your feature request related to a problem? Please describe
Currently, all of the data we receive from each Self-Hosted Gitpod instance (assuming the user did not opt-out) is anonymised. (For context, the only data we currently receive is at the aggregated level: Gitpod version, number of users, number of instances and number of workspaces). This means that although we can extract general insights from this data, we cannot specifically help individual customers as we have no way to identify them.
Describe the behaviour you'd like
Additional context
Internal slack threads (1,2)
The text was updated successfully, but these errors were encountered: