Skip to content

Commit

Permalink
[dashboard] display opening workspace when ide is not ready yet
Browse files Browse the repository at this point in the history
  • Loading branch information
mustard-mh committed Mar 30, 2022
1 parent 26f35e4 commit f8e204b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions components/dashboard/src/start/StartWorkspace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export interface StartWorkspaceProps {
* This flag is used to break the autostart-cycle explained in https://github.com/gitpod-io/gitpod/issues/8043
*/
dontAutostart: boolean;
notFound: boolean;
}

export function parseProps(workspaceId: string, search?: string): StartWorkspaceProps {
Expand All @@ -56,6 +57,7 @@ export function parseProps(workspaceId: string, search?: string): StartWorkspace
// - we assume the workspace has already been started for us
// - we don't know it's instanceId
dontAutostart: params.notFound || runsInIFrame,
notFound: params.notFound ?? false,
};
}

Expand Down Expand Up @@ -432,12 +434,12 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
if (!this.state.desktopIde) {
phase = StartPhase.Running;

if (this.props.dontAutostart) {
if (this.props.notFound) {
// hide the progress bar, as we're already running
phase = undefined;
title = "Running";

// in case we dontAutostart the IDE we have to provide controls to do so
// in case URL contain not_found we have to provide controls to do so
statusMessage = (
<div>
<div className="flex space-x-3 items-center text-left rounded-xl m-auto px-4 h-16 w-72 mt-4 mb-2 bg-gray-100 dark:bg-gray-800">
Expand Down

0 comments on commit f8e204b

Please sign in to comment.