Skip to content

Commit

Permalink
[supervisor] Provide port Name and Description along with the port st…
Browse files Browse the repository at this point in the history
…atus
  • Loading branch information
felladrin authored and roboquat committed Dec 20, 2021
1 parent fec0a0a commit f854940
Show file tree
Hide file tree
Showing 8 changed files with 616 additions and 153 deletions.
7 changes: 5 additions & 2 deletions components/gitpod-protocol/data/gitpod-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@
},
"name": {
"type": "string",
"deprecationMessage": "The 'name' property is deprecated.",
"description": "Port name (deprecated)."
"description": "Port name."
},
"protocol": {
"type": "string",
Expand All @@ -51,6 +50,10 @@
],
"deprecationMessage": "The 'protocol' property is deprecated.",
"description": "The protocol to be used. (deprecated)"
},
"description": {
"type": "string",
"description": "A description to identify what is this port used for."
}
},
"additionalProperties": false
Expand Down
8 changes: 5 additions & 3 deletions components/gitpod-protocol/go/gitpod-service.go
Original file line number Diff line number Diff line change
Expand Up @@ -1827,9 +1827,11 @@ type ImageConfigFile struct {

// PortConfig is the PortConfig message type
type PortConfig struct {
OnOpen string `json:"onOpen,omitempty"`
Port float64 `json:"port,omitempty"`
Visibility string `json:"visibility,omitempty"`
OnOpen string `json:"onOpen,omitempty"`
Port float64 `json:"port,omitempty"`
Visibility string `json:"visibility,omitempty"`
Description string `json:"description,omitempty"`
Name string `json:"name,omitempty"`
}

// ResolvedPlugins is the ResolvedPlugins message type
Expand Down
2 changes: 2 additions & 0 deletions components/gitpod-protocol/src/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,8 @@ export interface PortConfig {
port: number;
onOpen?: PortOnOpen;
visibility?: PortVisibility;
description?: string;
name?: string;
}
export namespace PortConfig {
export function is(config: any): config is PortConfig {
Expand Down
227 changes: 124 additions & 103 deletions components/supervisor-api/go/status.pb.go

Large diffs are not rendered by default.

Loading

0 comments on commit f854940

Please sign in to comment.