Use allSettled

gitpod-io · Mar 9, 2022 · f6daeab · f6daeab
1 parent 1e8da5c
commit f6daeab
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/components/server/src/code-sync/code-sync-service.ts b/components/server/src/code-sync/code-sync-service.ts
@@ -255,11 +255,8 @@ export class CodeSyncService {
                 }
                 oldRevList = oldRevs
             }, { latestRev, revLimit });
-            // delete old revs from storage
-            this.deleteObjects(userId, resourceKey, oldRevList).catch(e => {
-                // just in case
-                log.error({ userId }, 'code sync: failed to delete while insert', e);
-            })
+            // sync delete old revs from storage
+            this.deleteObjects(userId, resourceKey, oldRevList)
             if (!rev) {
                 res.sendStatus(412);
                 return;
@@ -311,7 +308,7 @@ export class CodeSyncService {
         }).catch(err => {
             log.error({ userId }, 'code sync: failed to delete', err);
         }))
-        return Promise.all(tasks)
+        return Promise.allSettled(tasks)
     }
 
 }