made tracing optional

gitpod-io · Dec 2, 2021 · f597616 · f597616
1 parent fc0c0a6
commit f597616
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/.werft/build.ts b/.werft/build.ts
@@ -548,7 +548,9 @@ export async function deployToDev(deploymentConfig: DeploymentConfig, workspaceF
         } else if (!!deploymentConfig.analytics) {
             flags += ` --set analytics.writer=${deploymentConfig.analytics!}`;
         }
-
+        if (deploymentConfig.withObservability) {
+            flags += ` --set tracing.enabled=true`;
+        }
         werft.log("helm", "extracting versions");
         try {
             exec(`docker run --rm eu.gcr.io/gitpod-core-dev/build/versions:${version} cat /versions.yaml | tee versions.yaml`);

diff --git a/.werft/values.dev.yaml b/.werft/values.dev.yaml
@@ -13,6 +13,7 @@ imagePullPolicy: Always
 
 authProviders: []
 tracing:
+  enabled: false
   endpoint: http://otel-collector:14268/api/traces
   samplerType: const
   samplerParam: "1"

diff --git a/chart/templates/_helpers.tpl b/chart/templates/_helpers.tpl
@@ -258,7 +258,7 @@ env:
 {{- $gp := .gp -}}
 {{- $comp := .comp -}}
 {{- $tracing := $comp.tracing | default $gp.tracing -}}
-{{- if $tracing }}
+{{- if $tracing.enabled }}
 {{- if $tracing.endpoint }}
 - name: JAEGER_ENDPOINT
   value: {{ $tracing.endpoint }}

diff --git a/chart/values.yaml b/chart/values.yaml
@@ -74,7 +74,11 @@ dbEncryptionKeys:
   secretName: null
   file: secrets/encryption-key.json
 
-tracing: {}
+tracing:
+  enabled: false
+  endpoint: http://<ENDPOINT_URL>
+  samplerType: const
+  samplerParam: "1"
 authProviders: []
 # Example authProvider configurations below:
 # - id: "Public-GitHub"