Add workspapce ID annotation to VolumeSnapshot object for filter event

Signed-off-by: JenTing Hsiao <[email protected]>
gitpod-io · Sep 15, 2022 · df91671 · df91671
1 parent 7c45c85
commit df91671
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/components/ws-manager/pkg/manager/manager.go b/components/ws-manager/pkg/manager/manager.go
@@ -453,8 +453,9 @@ func (m *Manager) restoreVolumeSnapshotFromHandle(ctx context.Context, id, handl
 	snapshotContentName := "restored-" + id
 	volumeSnapshot := &volumesnapshotv1.VolumeSnapshot{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      id,
-			Namespace: m.Config.Namespace,
+			Name:        id,
+			Namespace:   m.Config.Namespace,
+			Annotations: map[string]string{workspaceIDAnnotation: id},
 		},
 		Spec: volumesnapshotv1.VolumeSnapshotSpec{
 			Source: volumesnapshotv1.VolumeSnapshotSource{

diff --git a/components/ws-manager/pkg/manager/monitor.go b/components/ws-manager/pkg/manager/monitor.go
@@ -1128,9 +1128,10 @@ func (m *Monitor) finalizeWorkspaceContent(ctx context.Context, wso *workspaceOb
 				// create snapshot object out of PVC
 				volumeSnapshot := &volumesnapshotv1.VolumeSnapshot{
 					ObjectMeta: metav1.ObjectMeta{
-						Name:      pvcVolumeSnapshotName,
-						Namespace: m.manager.Config.Namespace,
-						Labels:    wso.Pod.Labels,
+						Name:        pvcVolumeSnapshotName,
+						Namespace:   m.manager.Config.Namespace,
+						Annotations: map[string]string{workspaceIDAnnotation: workspaceID},
+						Labels:      wso.Pod.Labels,
 					},
 					Spec: volumesnapshotv1.VolumeSnapshotSpec{
 						Source: volumesnapshotv1.VolumeSnapshotSource{

diff --git a/components/ws-manager/pkg/manager/volume_snapshot_controller.go b/components/ws-manager/pkg/manager/volume_snapshot_controller.go
@@ -37,6 +37,11 @@ func (r *VolumeSnapshotReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 		return reconcile.Result{}, nil
 	}
 
+	queue := vs.Annotations[workspaceIDAnnotation]
+	if queue == "" {
+		return ctrl.Result{}, nil
+	}
+
 	r.Monitor.eventpool.Add(vs.Name, watch.Event{
 		Type:   watch.Modified,
 		Object: &vs,