made tracing optional

/werft with-observability
gitpod-io · Dec 2, 2021 · bdca791 · bdca791
1 parent fc0c0a6
commit bdca791
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/.werft/build.ts b/.werft/build.ts
@@ -548,7 +548,9 @@ export async function deployToDev(deploymentConfig: DeploymentConfig, workspaceF
         } else if (!!deploymentConfig.analytics) {
             flags += ` --set analytics.writer=${deploymentConfig.analytics!}`;
         }
-
+        if (deploymentConfig.withObservability) {
+            flags += `-f ../.werft/values.tracing.yaml`;
+        }
         werft.log("helm", "extracting versions");
         try {
             exec(`docker run --rm eu.gcr.io/gitpod-core-dev/build/versions:${version} cat /versions.yaml | tee versions.yaml`);

diff --git a/.werft/values.dev.yaml b/.werft/values.dev.yaml
@@ -12,10 +12,6 @@ version: not-set
 imagePullPolicy: Always
 
 authProviders: []
-tracing:
-  endpoint: http://otel-collector:14268/api/traces
-  samplerType: const
-  samplerParam: "1"
 
 # we hit the "max. 110 pods/node" situation pretty often with our current core-dev setup.
 # the proper way to fix those would be to adjust the CIDR for workload NodePool which is a bit more work.

diff --git a/.werft/values.tracing.yaml b/.werft/values.tracing.yaml
@@ -0,0 +1,4 @@
+tracing:
+  endpoint: http://otel-collector:14268/api/traces
+  samplerType: const
+  samplerParam: "1"