Skip to content

Commit

Permalink
[ws-daemon] Remove user namespace variance
Browse files Browse the repository at this point in the history
  • Loading branch information
csweichel committed Apr 9, 2021
1 parent 055115b commit 5a7da93
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 1 addition & 3 deletions components/ws-daemon/pkg/content/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,6 @@ func (s *WorkspaceService) creator(req *api.InitWorkspaceRequest, upperdir strin
InstanceID: req.Id,
FullWorkspaceBackup: req.FullWorkspaceBackup,
ContentManifest: req.ContentManifest,
UserNamespaced: true,

ServiceLocDaemon: filepath.Join(s.config.WorkingArea, req.Id+"-daemon"),
ServiceLocNode: filepath.Join(s.config.WorkingAreaNode, req.Id+"-daemon"),
Expand Down Expand Up @@ -480,8 +479,7 @@ func (s *WorkspaceService) uploadWorkspaceContent(ctx context.Context, sess *ses
}()

var opts []archive.TarOption
// TODO (aledbf): remove after April release (user namespace is not a feature preview)
if !sess.FullWorkspaceBackup && sess.UserNamespaced {
if !sess.FullWorkspaceBackup {
mappings := []archive.IDMapping{
{ContainerID: 0, HostID: wsinit.GitpodUID, Size: 1},
{ContainerID: 1, HostID: 100000, Size: 65534},
Expand Down
2 changes: 0 additions & 2 deletions components/ws-daemon/pkg/internal/session/workspace.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ type Workspace struct {

ServiceLocNode string `json:"serviceLocNode"`
ServiceLocDaemon string `json:"serviceLocDaemon"`
// TODO (aledbf): remove after April release (user namespace is not a feature preview)
UserNamespaced bool `json:"userNamespaced"`

NonPersistentAttrs map[string]interface{} `json:"-"`

Expand Down

0 comments on commit 5a7da93

Please sign in to comment.