add PVC feature flag

gitpod-io · Apr 5, 2022 · 5a62315 · 5a62315
1 parent da28f0c
commit 5a62315
Show file tree

Hide file tree

Showing 10 changed files with 98 additions and 80 deletions.
diff --git a/components/gitpod-protocol/src/protocol.ts b/components/gitpod-protocol/src/protocol.ts
@@ -151,7 +151,11 @@ export interface UserFeatureSettings {
  * The values of this type MUST MATCH enum values in WorkspaceFeatureFlag from ws-manager/client/core_pb.d.ts
  * If they don't we'll break things during workspace startup.
  */
-export const WorkspaceFeatureFlags = { full_workspace_backup: undefined, fixed_resources: undefined };
+export const WorkspaceFeatureFlags = {
+    full_workspace_backup: undefined,
+    fixed_resources: undefined,
+    persistent_volume_claim: undefined,
+};
 export type NamedWorkspaceFeatureFlag = keyof typeof WorkspaceFeatureFlags;
 
 export interface EnvVarWithValue {

diff --git a/components/server/src/workspace/config-provider.ts b/components/server/src/workspace/config-provider.ts
@@ -127,7 +127,10 @@ export class ConfigProvider {
              */
             delete config._featureFlags;
             if (!!user.featureFlags) {
-                const workspacePersistedFlags: NamedWorkspaceFeatureFlag[] = ["full_workspace_backup"];
+                const workspacePersistedFlags: NamedWorkspaceFeatureFlag[] = [
+                    "full_workspace_backup",
+                    "persistent_volume_claim",
+                ];
                 config._featureFlags = workspacePersistedFlags.filter((f) =>
                     (user.featureFlags!.permanentWSFeatureFlags || []).includes(f),
                 );

diff --git a/components/ws-manager-api/core.proto b/components/ws-manager-api/core.proto
@@ -523,6 +523,9 @@ enum WorkspaceFeatureFlag {
 
     // Was used for UserNamespace
     reserved 6;
+
+    // PERSISTENT_VOLUME_CLAIM feature flag for enabling PVC\Snapshot feature support
+    PERSISTENT_VOLUME_CLAIM = 7;
 }
 
 // GitSpec configures the Git available within the workspace

diff --git a/components/ws-manager-api/go/core.pb.go b/components/ws-manager-api/go/core.pb.go
diff --git a/components/ws-manager-api/go/core_grpc.pb.go b/components/ws-manager-api/go/core_grpc.pb.go
diff --git a/components/ws-manager-api/go/mock/mock.go b/components/ws-manager-api/go/mock/mock.go
diff --git a/components/ws-manager-api/typescript/src/core_grpc_pb.d.ts b/components/ws-manager-api/typescript/src/core_grpc_pb.d.ts
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2021 Gitpod GmbH. All rights reserved.
+ * Copyright (c) 2022 Gitpod GmbH. All rights reserved.
  * Licensed under the GNU Affero General Public License (AGPL).
  * See License-AGPL.txt in the project root for license information.
  */

diff --git a/components/ws-manager-api/typescript/src/core_grpc_pb.js b/components/ws-manager-api/typescript/src/core_grpc_pb.js
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2021 Gitpod GmbH. All rights reserved.
+ * Copyright (c) 2022 Gitpod GmbH. All rights reserved.
  * Licensed under the GNU Affero General Public License (AGPL).
  * See License-AGPL.txt in the project root for license information.
  */

diff --git a/components/ws-manager-api/typescript/src/core_pb.d.ts b/components/ws-manager-api/typescript/src/core_pb.d.ts
@@ -1033,6 +1033,7 @@ export enum WorkspaceFeatureFlag {
     NOOP = 0,
     FULL_WORKSPACE_BACKUP = 4,
     FIXED_RESOURCES = 5,
+    PERSISTENT_VOLUME_CLAIM = 7,
 }
 
 export enum WorkspaceType {

diff --git a/components/ws-manager-api/typescript/src/core_pb.js b/components/ws-manager-api/typescript/src/core_pb.js
@@ -7991,7 +7991,8 @@ proto.wsman.WorkspacePhase = {
 proto.wsman.WorkspaceFeatureFlag = {
   NOOP: 0,
   FULL_WORKSPACE_BACKUP: 4,
-  FIXED_RESOURCES: 5
+  FIXED_RESOURCES: 5,
+  PERSISTENT_VOLUME_CLAIM: 7
 };
 
 /**