Allow job parallel running instead of replace

When using concurrentPolicy=Replace and the job failed but haven't reach the backoff limit, the new job will replace the original one if the schedule time is less than the sum of the backoff time. It causes a problem that the job alert `kube_job_status_failed{job_name=~"refresh-credential.*",reason="BackoffLimitExceeded"}` can't be fired. Signed-off-by: JenTing Hsiao <[email protected]>
gitpod-io · Dec 15, 2022 · 2697c6a · 2697c6a
1 parent c09d2f9
commit 2697c6a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/install/installer/cmd/testdata/render/aws-setup/output.golden b/install/installer/cmd/testdata/render/aws-setup/output.golden
diff --git a/install/installer/pkg/components/refresh-credential/cronjob.go b/install/installer/pkg/components/refresh-credential/cronjob.go
@@ -63,8 +63,8 @@ func cronjob(ctx *common.RenderContext) ([]runtime.Object, error) {
 			Spec: batchv1.CronJobSpec{
 				Schedule:                   CronSchedule,
 				SuccessfulJobsHistoryLimit: pointer.Int32(1),
-				FailedJobsHistoryLimit:     pointer.Int32(10),
-				ConcurrencyPolicy:          batchv1.ReplaceConcurrent,
+				FailedJobsHistoryLimit:     pointer.Int32(1),
+				ConcurrencyPolicy:          batchv1.AllowConcurrent,
 				JobTemplate: batchv1.JobTemplateSpec{
 					ObjectMeta: objectMeta,
 					Spec: batchv1.JobSpec{