Skip to content

Commit

Permalink
Skip the cannot mount workspace event because it might be an intermed…
Browse files Browse the repository at this point in the history
…iate state

Signed-off-by: JenTing Hsiao <[email protected]>
  • Loading branch information
jenting authored and roboquat committed Nov 3, 2022
1 parent 5fffa02 commit 0a130f1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions components/ws-manager/pkg/manager/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -620,8 +620,8 @@ func extractFailure(wso workspaceObjects, metrics *metrics) (string, *api.Worksp
// ref: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/issues/608
return "", nil
} else if strings.Contains(evt.Message, workspaceVolumeName) {
// ideally we do not just use evt.Message as failure reason because it contains internal paths and is not useful for the user
return "cannot mount workspace", nil
// ref: https://github.com/gitpod-io/gitpod/issues/14032
return "", nil
} else {
// if this happens we did not do a good job because that means we've introduced another volume to the pod
// but did not consider that mounting it might fail.
Expand Down

0 comments on commit 0a130f1

Please sign in to comment.