Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roboquat does not move issues to review column in groundwork even if labels are applied correctly #33

Closed
gtsiolis opened this issue Oct 5, 2021 · 4 comments · Fixed by #42
Assignees
Labels
bug Something isn't working

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 5, 2021

Bug description

When gitpod-io/gitpod#6048 was opened, @roboquat requested reviews in gitpod-io/gitpod#6048 (comment) and labels were updated in the corresponding issue in gitpod-io/gitpod#5050 (comment), however, the issue was not moved to the review column in groundwork[1], see gitpod-io/gitpod#5050 (comment).

Steps to reproduce

Have not tried reproducing this but approving the PR before @roboquat runs could be the root cause of this issue, see gitpod-io/gitpod#6048 (comment).

Expected behavior

No response

Example repository

No response

Anything else?

No response

@gtsiolis gtsiolis transferred this issue from gitpod-io/gitpod Oct 5, 2021
@laushinka
Copy link
Contributor

Not sure if I should add here (please let me know if I should create a different issue), but Roboquat is also not moving columns for the following tickets:

@JanKoehnlein JanKoehnlein added the bug Something isn't working label Oct 6, 2021
@meysholdt
Copy link
Member

Removing from platform inbox, because in terms of priorities we need to focus on SOC2 for now.

Furthermore, there are unclear technical challenges:

  • how to map PRs to Gitpod-versions, because commit-sh1 change on pr-merge.
  • how to deal with PRs that are not local to a meta-deployment, ide-deployment or workspace-deployment? Those PRs are practically in a "half deployed" state.

@ArthurSens
Copy link
Contributor

Furthermore, there are unclear technical challenges:

  • how to map PRs to Gitpod-versions, because commit-sh1 change on pr-merge.

Prow has 2 important concepts for jobs. presubmits and postsubmits which act on pull requests and merges, respectively. I believe we need a postsubmit job that can do all the "after merge work" such as:

  • Deploying to staging
  • Deploying to production (Big maybe here)
  • Move cards to "Deployed" in Groundwork projects

See also: https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md

@JanKoehnlein
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants