Skip to content

Commit

Permalink
Download latest binary & Add CODEOWNERS (#6)
Browse files Browse the repository at this point in the history
* Download latest binary

* Add CODEOWNERS

* Check to enable private DNS in VPC endpoints
  • Loading branch information
kylos101 authored Jul 19, 2024
1 parent 9106ae5 commit d48a8c7
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @gitpod-io/team-engine @gitpod-io/team-enterprise
8 changes: 6 additions & 2 deletions gitpod-network-check/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@ A CLI to check if your network setup is suitable for the installation of Gitpod.

## Prerequisites

1. Download the `gitpod-network-check` binary using:
1. Download the latest `gitpod-network-check` binary using:
```
curl -L "https://github.com/gitpod-io/enterprise-deployment-toolkit/releases/download/v0.1.3/enterprise-deployment-toolkit_$(uname -s -m | awk '{print $1"_"$2}').tar.gz" | tar -xz
curl -s https://api.github.com/repos/gitpod-io/enterprise-deployment-toolkit/releases/latest | \
grep "browser_download_url.*$(uname -s)_$(uname -m)" | \
cut -d : -f 2,3 | \
tr -d \" | \
xargs curl -L | tar -xz
```

You can also download and untar the binary directly from the Github releases page [here](https://github.com/gitpod-io/enterprise-deployment-toolkit/releases/latest)
Expand Down
5 changes: 5 additions & 0 deletions gitpod-network-check/cmd/checks.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,11 @@ func checkSMPrerequisites(ctx context.Context, ec2Client *ec2.Client) error {
}
log.Infof("ℹ️ VPC endpoint %s is not configured", endpoint.Endpoint)
} else {
for _, e := range response.VpcEndpoints {
if e.PrivateDnsEnabled != nil && !*e.PrivateDnsEnabled {
log.Errorf("❌ VPC endpoint '%s' has private DNS disabled, it must be enabled", *e.VpcEndpointId)
}
}
log.Infof("✅ VPC endpoint %s is configured", endpoint.Endpoint)
}
}
Expand Down

0 comments on commit d48a8c7

Please sign in to comment.