hardcode gitleaks version #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weineran
approved these changes
Aug 2, 2022
| let gitleaksVersion = | ||
| process.env.GITLEAKS_VERSION || (await gitleaks.Latest(octokit)); | ||
|
|
||
| let gitleaksVersion = process.env.GITLEAKS_VERSION || "8.9.0"; |
There was a problem hiding this comment.
Not specific to this PR, but what happens if the user sets the env variable to an invalid version string by mistake? e.g. "8.90" instead of "8.9.0"
Can we catch that on line 120?
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Jan 27, 2023
See the source for the "latest" version logic https://github.com/gitleaks/gitleaks-action/blob/1f2d10fb689bc07a5f56f48d6db61f5bbbe772fa/src/index.js#L134-L135 See this PR that hard-codes the version for reasons why gitleaks/gitleaks-action#78
This was referenced Jan 27, 2023
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Jan 27, 2023
See the source for the "latest" version logic https://github.com/gitleaks/gitleaks-action/blob/1f2d10fb689bc07a5f56f48d6db61f5bbbe772fa/src/index.js#L134-L135 See this PR that hard-codes the version for reasons why gitleaks/gitleaks-action#78 This PR adds the missing documentation gitleaks/gitleaks-action#109
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Jan 27, 2023
See the source for the "latest" version logic https://github.com/gitleaks/gitleaks-action/blob/1f2d10fb689bc07a5f56f48d6db61f5bbbe772fa/src/index.js#L134-L135 See this PR that hard-codes the version for reasons why gitleaks/gitleaks-action#78
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Jan 27, 2023
See the source for the "latest" version logic https://github.com/gitleaks/gitleaks-action/blob/1f2d10fb689bc07a5f56f48d6db61f5bbbe772fa/src/index.js#L134-L135 See this PR that hard-codes the version for reasons why gitleaks/gitleaks-action#78 This PR adds the missing documentation gitleaks/gitleaks-action#109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weineran mind reviewing this too? I think we should default to using a hardcoded version rather than always pulling latest for two reasons: