Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload report artifact even if there are no leaks detected #106

Merged

Conversation

weineran
Copy link
Contributor

Currently, the report artifact is only uploaded if secrets are detected. This makes it hard to use the report in the next step of a GitHub Actions pipeline b/c it's not easy (maybe not even possible?) to check if an artifact exists in the middle of a workflow before downloading it.

This change makes it so that we upload the artifact unconditionally on every run.

@weineran weineran added the enhancement New feature or request label Nov 22, 2022
@weineran weineran requested a review from zricethezav November 22, 2022 16:19
@weineran weineran self-assigned this Nov 22, 2022
@zricethezav
Copy link
Collaborator

@weineran makes sense to me 👍🏻

@zricethezav zricethezav merged commit bf99855 into master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants