Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datasource/gitlab_group_membership: support pagination. Closes #466 #858

Merged
merged 2 commits into from
Feb 11, 2022
Merged

datasource/gitlab_group_membership: support pagination. Closes #466 #858

merged 2 commits into from
Feb 11, 2022

Conversation

timofurrer
Copy link
Member

Closes #466

@timofurrer timofurrer requested a review from armsnyder February 9, 2022 17:09
@timofurrer timofurrer self-assigned this Feb 9, 2022
@github-actions github-actions bot added data-source Adds or modifies a data-source provider tests size/M labels Feb 9, 2022
@timofurrer timofurrer force-pushed the datasources/pagination branch from 4834454 to 2358c79 Compare February 9, 2022 17:11
@timofurrer timofurrer added this to the v3.10.0 milestone Feb 9, 2022
@timofurrer timofurrer force-pushed the datasources/pagination branch from 2358c79 to cf60ac3 Compare February 9, 2022 17:13
armsnyder
armsnyder approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! Test can probably be cleaned up if you have time.

internal/provider/data_source_gitlab_group_membership_test.go Outdated Show resolved Hide resolved
@armsnyder armsnyder mentioned this pull request Feb 11, 2022
Merged
@timofurrer timofurrer force-pushed the datasources/pagination branch from cf60ac3 to f85db4b Compare February 11, 2022 07:59
@timofurrer timofurrer merged commit 2dea817 into gitlabhq:main Feb 11, 2022
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armsnyder armsnyder armsnyder approved these changes

Assignees

@timofurrer timofurrer

Labels
data-source Adds or modifies a data-source provider size/M tests
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timofurrer @armsnyder