Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added releases event webhook option #773

Merged

Conversation

hnaderi
Copy link
Contributor

@hnaderi hnaderi commented Dec 27, 2021

Added releases event option to project webhook resource and updated test and document

Copy link
Member

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

Looks good to me - can you please rebase to latest master and address the small comment I've left.

gitlab/resource_gitlab_project_hook.go Outdated Show resolved Hide resolved
@timofurrer timofurrer added needs-rebase For PRs which need a rebase upstream api alignment For issues and PRs which are aligning the provider implementation with the upstream GitLab API spec enhancement labels Feb 1, 2022
@hnaderi hnaderi force-pushed the add-releases-event-to-project-hook branch 3 times, most recently from fdaad0e to 05feff6 Compare February 1, 2022 12:39
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the merge-conflict PR cannot be merged due to a merge conflict label Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request has merge conflicts. Please rebase your branch onto main.

@hnaderi hnaderi force-pushed the add-releases-event-to-project-hook branch from 05feff6 to d974dd6 Compare February 7, 2022 09:21
@github-actions github-actions bot removed the merge-conflict PR cannot be merged due to a merge conflict label Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Conflicts are resolved. Thank you! 😀

@timofurrer timofurrer added this to the v3.10.0 milestone Feb 7, 2022
@timofurrer timofurrer merged commit 8e64303 into gitlabhq:main Feb 7, 2022
@github-actions github-actions bot removed the needs-rebase For PRs which need a rebase label Feb 7, 2022
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation enhancement provider resource Adds or modifies a resource size/S tests upstream api alignment For issues and PRs which are aligning the provider implementation with the upstream GitLab API spec
Development

Successfully merging this pull request may close these issues.

3 participants