-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable unsubscribing notifications #407
Conversation
Can I suggest that we use the same icon as GitHub? 😉 |
817b010
to
a3c5020
Compare
f408d71
to
c76f5cd
Compare
I feel like it shouldn't be next to "✔" as it's not a primary action so what I did was to place it on the same line with the "reason" and "date" and it's visible only when you hover over a notification. This way we have more space more icons in the future (if needed). Thoughts on the gif? cc @codebytere @JakeSidSmith |
I wouldn't have it hidden until hover, especially as it will also mark the notification as complete. I imagine people would be likely to click it without meaning to and then struggle to find it again. |
I'd agree with @JakeSidSmith - definitely better to make it a secondary action but perhaps keep it visible by default 🤔 would something like this be fine, or would you prefer the new button to be right-aligned? |
Maybe right aligned and always visible would be perfect if you agree? I think we will have to remove it from the list as well - like we do when pressing on the "check"? |
daafb21
to
284a92e
Compare
@manosim i believe this should be good to go now! Let me know if there are any other tests you'd like me to add, but i covered the basics based on what i saw was already there. The new UI is updated in the main PR body as well, but it looks like this now (the red is on hover): |
Amazing - thank you for sorting this out @codebytere ! 🎉 |
@codebytere Can you try pushing an empty commit? It looks like GitHub Actions didn't pick up this PR 😢 |
284a92e
to
83fc82e
Compare
83fc82e
to
d16df13
Compare
Closes #402.
When the new unsubscribe icon is clicked, all future notifications for a conversation are muted until one comments on the thread or gets an @mention.
cc @manosim