Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable unsubscribing notifications #407

Merged
merged 4 commits into from
May 5, 2020

Conversation

codebytere
Copy link
Collaborator

@codebytere codebytere commented May 3, 2020

Closes #402.

When the new unsubscribe icon is clicked, all future notifications for a conversation are muted until one comments on the thread or gets an @mention.

Screen Shot 2020-05-04 at 4 32 02 PM

cc @manosim

@JakeSidSmith
Copy link
Collaborator

Can I suggest that we use the same icon as GitHub? 😉
https://primer.style/octicons/mute

@codebytere codebytere marked this pull request as ready for review May 3, 2020 20:07
@codebytere codebytere force-pushed the add-unsubscribe-button branch 2 times, most recently from f408d71 to c76f5cd Compare May 3, 2020 20:16
@manosim
Copy link
Member

manosim commented May 3, 2020

I feel like it shouldn't be next to "✔" as it's not a primary action so what I did was to place it on the same line with the "reason" and "date" and it's visible only when you hover over a notification. This way we have more space more icons in the future (if needed). Thoughts on the gif? cc @codebytere @JakeSidSmith

vJnAul77c4

@JakeSidSmith
Copy link
Collaborator

JakeSidSmith commented May 3, 2020

I wouldn't have it hidden until hover, especially as it will also mark the notification as complete. I imagine people would be likely to click it without meaning to and then struggle to find it again.

@codebytere
Copy link
Collaborator Author

codebytere commented May 4, 2020

I'd agree with @JakeSidSmith - definitely better to make it a secondary action but perhaps keep it visible by default 🤔

would something like this be fine, or would you prefer the new button to be right-aligned?

Screen Shot 2020-05-03 at 5 10 36 PM

@manosim
Copy link
Member

manosim commented May 4, 2020

Maybe right aligned and always visible would be perfect if you agree? I think we will have to remove it from the list as well - like we do when pressing on the "check"?

@codebytere codebytere force-pushed the add-unsubscribe-button branch 3 times, most recently from daafb21 to 284a92e Compare May 5, 2020 02:14
@codebytere
Copy link
Collaborator Author

codebytere commented May 5, 2020

@manosim i believe this should be good to go now! Let me know if there are any other tests you'd like me to add, but i covered the basics based on what i saw was already there. The new UI is updated in the main PR body as well, but it looks like this now (the red is on hover):

Screen Shot 2020-05-04 at 4 32 02 PM

@manosim
Copy link
Member

manosim commented May 5, 2020

Amazing - thank you for sorting this out @codebytere ! 🎉
Will give it a couple of days and will cut a new release if nothing else comes up.

@manosim
Copy link
Member

manosim commented May 5, 2020

@codebytere Can you try pushing an empty commit? It looks like GitHub Actions didn't pick up this PR 😢

@manosim manosim merged commit 2856135 into gitify-app:master May 5, 2020
@codebytere codebytere mentioned this pull request May 7, 2020
@codebytere codebytere deleted the add-unsubscribe-button branch July 29, 2020 17:52
@setchy setchy added the enhancement New feature or enhancement to existing functionality label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI for unsubscribing a PR notification?
4 participants