feat(settings): disable show accounts when multiple accounts are authenticated
#1439
Conversation
…henticated Signed-off-by: Adam Setch <[email protected]>
github-actions
bot
added
the
enhancement
Signed-off-by: Adam Setch <[email protected]>
| @@ -218,3 +218,11 @@ export function isValidToken(token: Token) { | |||
| export function getAccountUUID(account: Account): string { | |||
| return btoa(`${account.hostname}-${account.user.id}-${account.method}`); | |||
| } | |||
|
|
|||
| export function hasAccounts(auth: AuthState) { | |||
| @@ -198,7 +199,8 @@ export const AppearanceSettings: FC = () => { | |||
| <Checkbox | |||
| name="showAccountHostname" | |||
| label="Show account hostname" | |||
| checked={settings.showAccountHostname} | |||
| checked={settings.showAccountHostname || hasMultipleAccounts(auth)} | |||
| disabled={hasMultipleAccounts(auth)} | |||
There was a problem hiding this comment.
Why exactly do we need to disable this on multiple accounts?
There was a problem hiding this comment.
Because of this prop
gitify/src/routes/Notifications.tsx
Lines 45 to 46 in e7b843b
There was a problem hiding this comment.
I see, but can't the hostname be the same on some situations?
There was a problem hiding this comment.
Indeed, we support repeated hostnames now.
There was a problem hiding this comment.
so single account, feature flag toggles showing the account header
multiple accounts, feature flag does nada
There was a problem hiding this comment.
Right, but does it make sense for it to be disabled on the situations where it is the same for example?
There was a problem hiding this comment.
showAccountHostname is misleading nowdays. It really should be showAccountNameHeader or something like that as it represents the row containing account name, account avatar, account platform type, etc
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Toggling this setting has no affect when there are multiple accounts authenticated.