refactor: fix biomejs lint warning #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
bmulholland
approved these changes
Jul 29, 2024
afonsojramos
reviewed
Aug 8, 2024
| @@ -173,7 +173,7 @@ export const AppProvider = ({ children }: { children: ReactNode }) => { | |||
| const newSettings = { ...settings, ...defaultFilters }; | |||
| setSettings(newSettings); | |||
| saveState({ auth, settings: newSettings }); | |||
| }, [auth]); | |||
| }, [auth, settings]); | |||
There was a problem hiding this comment.
Be careful with this 👀 All linters are known for sometimes inducing people in error with this, for example in useEffects
There was a problem hiding this comment.
Thanks. So for this instance do you think this should be reverted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.