Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command to add database source folder to workspace #891

Merged
merged 3 commits into from
Jun 25, 2021

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Jun 25, 2021

Will fix #798.

As described in the linked issue, we don't have an easy way of re-adding a database's source folder to the workspace. This PR adds a new command (in the Databases View) that lets you re-add a source folder.

(We also considered re-adding source folders automatically, similar to how the codeQLDatabases.removeOrphanedDatabases command is run, but I'm now wondering if that'll be annoying to users. They may have deliberately removed a source folder from their workspace, and don't want it included automatically 🤔 I'm open to suggestions though!)

PS: In the process, I found a small bug in how we upgrade databases. (Opened an issue here #890, but haven't worked out how to fix that yet! 😅)

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • @github/docs-content-codeql has been cc'd in all issues for UI or other user-facing changes made by this pull request.
    • I don't think a docs change is necessary, since the docs don't describe database commands in detail anyway. We just say the following, which is still valid 🙂

      To see the menu options for interacting with a database, right-click an entry in the list. You can select multiple databases using Ctrl/Cmd+click.

@shati-patel shati-patel marked this pull request as ready for review June 25, 2021 17:31
@shati-patel shati-patel requested a review from a team as a code owner June 25, 2021 17:31
@aeisenberg
Copy link
Contributor

Good point about users explicitly removing the source folder.

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. This should have a changelog entry and then we can merge it.

@shati-patel
Copy link
Contributor Author

Nicely done. This should have a changelog entry and then we can merge it.

Thanks for the review! I've checked the docs for changes (none needed) and updated the changelog 📝

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@aeisenberg aeisenberg merged commit 1a18c6d into main Jun 25, 2021
@aeisenberg aeisenberg deleted the shati-patel/readd-db-source branch June 25, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support re-adding database source to workspace
2 participants