Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version info while downloading #862

Merged
merged 2 commits into from
May 14, 2021
Merged

Add version info while downloading #862

merged 2 commits into from
May 14, 2021

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented May 13, 2021 •
edited
Loading

Does this warrant a changelog entry?

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • @github/docs-content-codeql has been cc'd in all issues for UI or other user-facing changes made by this pull request.

shati-patel
shati-patel approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!
image

It's a user-visible change, so I think a changelog entry is still a good idea :)

@aeisenberg
Copy link
Contributor Author

Changelog updated.

@aeisenberg aeisenberg enabled auto-merge (rebase) May 14, 2021 14:54
@aeisenberg aeisenberg merged commit c4b1225 into main May 14, 2021
@aeisenberg aeisenberg deleted the aeisenberg/cli-version-popup branch May 14, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

@adityasharad adityasharad Awaiting requested review from adityasharad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeisenberg @shati-patel